1607801 - Improve module loading TypeScript definitions

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), task, P3)

Description

[Greg Tatum [:gregtatum]]

Right now the module loading is a bit verbose with lots of boilerplate. This can be improved.

Comment 1

[Greg Tatum [:gregtatum]]

Attachment: Bug 1607801 - Pre-define ChromeUtils.import paths; r?julienw

Comment 2

[Greg Tatum [:gregtatum]]

Attachment: Bug 1607801 - Create a mechanism to define "require" for TypeScript; r?julienw,ochameau

Previously we had to use an annoying method of coercing the global "this"
into an "any" type, then set the "require" property to the browser loader's
"require" function. This patch adds that typing mechanism to the DevTools'
loader system, making it a bit more ergonomic to use.

Depends on D59206

Comment 3

[Greg Tatum [:gregtatum]]

Attachment: Bug 1607801 - Create a TypeScript friendly lazy loading mechanism; r?julienw

Depends on D59207

Comment 4

[Greg Tatum [:gregtatum]]

ochameau: I took some time after your feedback to try and improve upon the loader situation to make it more ergonomic. The first patch I only have julien as the reviewer, but the next two I touch "real" files outside of the performance-new directory. I tried to balance the impact of performance, ergonomics, and type safety with the approach. Let me know what you think about the approach.

Comment 5

[Greg Tatum [:gregtatum]]

I'm leaving this open, as I would still like to rebase the ChromeUtils.import paths patch.

Comment 6

[Greg Tatum [:gregtatum]]

Attachment: Bug 1607801 - Upgrade TypeScript to v3.8.3; r?julienw

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/79e01e02fa5e
Upgrade TypeScript to v3.8.3; r=julienw
https://hg.mozilla.org/integration/autoland/rev/8dfe8cb5a831
Pre-define ChromeUtils.import paths; r=julienw
https://hg.mozilla.org/integration/autoland/rev/de5aad1dc90e
Create a TypeScript friendly lazy loading mechanism; r=ochameau

Comment 8

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/79e01e02fa5e
https://hg.mozilla.org/mozilla-central/rev/8dfe8cb5a831
https://hg.mozilla.org/mozilla-central/rev/de5aad1dc90e