1607940 - WebGL out-of-process prototype

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, enhancement, P1)

Comment 1

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1607940 - Stand up webgl.out-of-process:true path.

• Use clearer pref names.
• Default (and only support) IPDL dispatching.
• Make DispatchCommands async-only.
• Sync ipdl command per sync webgl entrypoint.
  • Eat the boilerplate cost, since there's not too many.
• Run SerializedSize off same path as Serialize.
• All shmem uploads go through normal DispatchCommands.
• Defer pruning of dead code for now so we can iterate quickly.
• Use Read/Write(begin,end) instead of (begin,size).
  • This would have prevented a bug where we read/wrote N*sizeof(T)*sizeof(T).

Comment 2

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1607940 - Add -oop mochitest jobs e.g. gl1c->rgl1c.

Comment 5

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1607940 - Add webgl-ipc (gli) CI variant.

Comment 6

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1607940 - IPC TexImage.

Comment 7

[Kelsey Gilbert [:jgilbert]]

Looking green on try (linux so far): https://treeherder.mozilla.org/#/jobs?repo=try&revision=5b3aaae2483c2cdcae56dbcec74234f6acbc4130
We're going to mark the (web)gli(pc) tests as tier-2 and finish getting them totally green separately.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/282eafdb9753
Stand up webgl.out-of-process:true path. r=handyman,nika,froydnj
https://hg.mozilla.org/integration/autoland/rev/9049a0173c60
Add webgl-ipc (gli) CI variant. r=ahal,jmaher
https://hg.mozilla.org/integration/autoland/rev/978c7a6ddb55
IPC TexImage. r=lsalzman,nika,handyman

Comment 9

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1607940 - Fix GCC -Werror.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e91281e2321a
Fix GCC -Werror.

Comment 11

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/282eafdb9753
https://hg.mozilla.org/mozilla-central/rev/9049a0173c60
https://hg.mozilla.org/mozilla-central/rev/978c7a6ddb55
https://hg.mozilla.org/mozilla-central/rev/e91281e2321a

Comment 12

[Alexandru Ionescu (needinfo me) [:alexandrui]]

== Change summary for alert #26566 (as of Tue, 21 Jul 2020 22:55:07 GMT) ==

Regressions:

40% glterrain windows7-32-shippable opt e10s stylo 1.18 -> 1.64
36% glterrain windows10-64-shippable opt e10s stylo 1.22 -> 1.65
14% glterrain macosx1014-64-shippable opt e10s stylo 3.90 -> 4.43

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=26566

Comment 13

[Joel Maher ( :jmaher ) (UTC -8)]

as per comment: https://searchfox.org/mozilla-central/source/taskcluster/taskgraph/transforms/tests.py#289
# TODO: After November 1st 2020, verify this variant is still needed.

I want to know if we still need this variant. If so, can we update the comment to include a new date to check in?

Comment 14

[Kelsey Gilbert [:jgilbert]]

Will do.

Comment 15

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1607940 - Extend m-gli variant use until 2021-02-01.

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b37b61bcad9f
Extend m-gli variant use until 2021-02-01. r=jmaher DONTBUILD

Comment 17

[Joel Maher ( :jmaher ) (UTC -8)]

sorry for another question- I am asking about windows7- we run mochitest-media-gli (opt+debug), windows7-minGW/debug-mochitest-webgl-gli and windows7-shippable/talos-webgl-gli

is 32 bit windows important? if it is, are we running the right tests there? I will be turning off the talos job as our value add from 32 bit windows perf testing is approaching 0, this is why I am asking as I need to hack a config and see other stuff there.

Comment 18

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/b37b61bcad9f

Comment 19

[Kelsey Gilbert [:jgilbert]]

(In reply to Joel Maher ( :jmaher ) (UTC -0800) from comment #17)

sorry for another question- I am asking about windows7- we run mochitest-media-gli (opt+debug), windows7-minGW/debug-mochitest-webgl-gli and windows7-shippable/talos-webgl-gli

is 32 bit windows important? if it is, are we running the right tests there? I will be turning off the talos job as our value add from 32 bit windows perf testing is approaching 0, this is why I am asking as I need to hack a config and see other stuff there.

We don't need talos/perf results from 32-bit, but we want (some) testing for correctness/crashes on 32bit for as long as we still support it.