Allow to set environment variables for launched GeckoView vehicles on Android
Categories
(Testing :: geckodriver, enhancement, P3)
Tracking
(firefox74 fixed)
| Tracking | Status | |
|---|---|---|
| firefox74 | --- | fixed |
People
(Reporter: nalexander, Assigned: nalexander)
References
Details
Attachments
(1 file)
There's no good way right now to set environment variables for Android GeckoView vehicles. geckodriver itself uses the GeckoView configuration file mechanism so it needs to help set the env: section in those files. I don't see any reason to make this Android only; it just hasn't arisen yet on Desktop because generally the device under test and the host are the same, and geckodriver inherits the launching environment.
|
Assignee | |
Comment 1•5 years ago
|
||
jesup: this is what you were asking for in various channels yesterday.
|
||
Comment 2•5 years ago
|
||
./mach run has the ability to set env vars (though I haven't tested that on android), and on desktop it's often easy to just set them in your cmdline shell or some app property. However, for automation (like geckodriver) it'd be nice not to have to do it that way. I'm not sure why I was NI'd, but we definitely would like to be able to set env vars for android runs without doing stuff like editing the yaml file by hand and pushing it to the phone.
|
|
Assignee | |
Comment 3•5 years ago
|
||
(In reply to Randell Jesup [:jesup] (needinfo me) from comment #2)
./mach run has the ability to set env vars (though I haven't tested that on android)
./mach run --setenv foo.bar=1 works on Android: Bug 1557805.
, and on desktop it's often easy to just set them in your cmdline shell or some app property. However, for automation (like geckodriver) it'd be nice not to have to do it that way. I'm not sure why I was NI'd, but we definitely would like to be able to set env vars for android runs without doing stuff like editing the yaml file by hand and pushing it to the phone.
I'm not sure why you were NI'd either. I have a patch for this working locally, I'll push it up in a moment.
|
|
Assignee | |
Comment 4•5 years ago
|
||
In general Desktop platforms can use the launching environment, which
is inherited by geckodriver; but that's not possible on Android, so we
introduce a new env map in Firefox options and ferry it through to
the GeckoView configuration file.
|
|
Assignee | |
Comment 6•5 years ago
|
||
The corresponding change to browsertime is up for review at https://github.com/sitespeedio/browsertime/pull/1110.
Nick, please remember to also file a follow-up bug for desktop. Thanks.
|
||
Comment 8•5 years ago
|
||
| bugherder | ||
|
|
Assignee | |
Comment 9•5 years ago
|
||
(In reply to Henrik Skupin (:whimboo) [⌚️UTC+1] from comment #7)
Nick, please remember to also file a follow-up bug for desktop. Thanks.
Looks like wires are still crossed after discussion in the reviews: I implemented this for Desktop and for Android, so no follow-up is needed.
With https://github.com/sitespeedio/browsertime/issues/1109 (not yet merged), I see MOZ_LOG logging printed to the console on Desktop when running
./mach browsertime -- -n 1 --firefox.geckodriverPath /Users/nalexander/Mozilla/gecko/target/debug/geckodriver https://example.com --firefox.binaryPath /Applications/Firefox\ Nightly.app/Contents/MacOS/firefox -vv --firefox.env='MOZ_LOG=nsHttp:5'
I see MOZ_LOG logging printed to adb logcat on Android when running
./mach browsertime -- --android -n 1 --firefox.binaryPath x --firefox.android.package org.mozilla.geckoview_example --firefox.android.activity .GeckoViewActivity --firefox.geckodriverPath /Users/nalexander/Mozilla/gecko/target/debug/geckodriver https://example.com -vv --firefox.env 'MOZ_LOG=nsHttp:5'
|
|
Assignee | |
Comment 10•5 years ago
|
||
That is, as long as the harness sets env in the moz:firefoxOptions block, it should make it to the launched process on both Desktop and Android. Try it out!
Description
•