1608036 - Loss of all pinned tabs except one

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect, P1)

Description

[Gian-Carlo Pascutto [:gcp]]

STR:

Restart firefox. Observe all pinned tabs are gone except one.

Very likely a regression from bug 1607441 which tried to fix the order reversal.

Comment 1

[Francesco Lodolo [:flod]]

For me it updated to 74.0a1 (2020-01-08) (64 bit) and didn't lose any pinned tab (I have 9). The only thing is that I reordered them before restarting, and I might have skipped one or two Nightlies. Update history:

Nightly 74.0a1 (20200108215606)
Nightly 74.0a1 (20200108094158)
Nightly 74.0a1 (20200107215758)

Comment 2

[:Gijs (he/him)]

Does anyone have steps to reproduce? Seems like it's working for some people and not for others, and it's hard to address without knowing what causes the difference...

Comment 3

[Dão Gottwald [:dao]]

(In reply to :Gijs (he/him) from comment #2)

Does anyone have steps to reproduce? Seems like it's working for some people and not for others, and it's hard to address without knowing what causes the difference...

We'll have to back out both patches as a last resort if we don't find another way to address this soon.

Comment 4

[Caspy7]

Welp. First it restarted with all but one (the one was previously focused I think), then I fixed them and tested again and it restarted with all the others present except the one that was left standing before. As I recall the missing tab showed up in URL bar as a tab I could switch to. Selecting that though did nothing.

Restarted an things are fine now (so it appears).

Comment 5

[Sven Marnach :sven]

I lose all pinned tabs after the one that's currently selected upon restart.

• If I restart with the first pinned tab selected, all other pinned tabs get lost.
• If I restart with the last pinned tab selected, I keep all tabs.
• If I restart with an unpinned tab selected, I also keep all tabs.

This is reproducible behaviour in both my browser profiles.

Comment 6

[:Gijs (he/him)]

(In reply to Sven Marnach from comment #5)

I lose all pinned tabs after the one that's currently selected upon restart.

• If I restart with the first pinned tab selected, all other pinned tabs get lost.
• If I restart with the last pinned tab selected, I keep all tabs.
• If I restart with an unpinned tab selected, I also keep all tabs.

This is reproducible behaviour in both my browser profiles.

Thanks, this was really helpful. I can reproduce and have written a test. Now "just" need to fix it...

Comment 7

[:Gijs (he/him)]

Attachment: Bug 1608036 - fix pinned tabs getting lost when restoring sessions, r?dao!,emalysz

Comment 8

[Gian-Carlo Pascutto [:gcp]]

Clearing as STR have been identified.

Comment 9

[zak.mcgregor]

I'm a little wary of piping up, but is there a way to restore lost pinned tabs please? I have lost about 50. Restarting FF has not restored them.

Comment 10

[:Gijs (he/him)]

(In reply to zak.mcgregor from comment #9)

I'm a little wary of piping up, but is there a way to restore lost pinned tabs please? I have lost about 50. Restarting FF has not restored them.

There are session store backup files in your profile that you could try using (with a downgraded nightly, or after waiting for a fix to land). If you more or less remember URLs / titles, you can get the URL to show by typing in the address bar and reopen them manually that way. Otherwise, no.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d306a8c775cb
fix pinned tabs getting lost when restoring sessions, r=dao

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/12bf9dc0978e
fix pinned tabs getting lost when restoring sessions, r=dao a=Aryx

Comment 15

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/12bf9dc0978e

Comment 16

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/d306a8c775cb

Comment 19

[Dão Gottwald [:dao]]

needinfo for gijs to file a followup for https://phabricator.services.mozilla.com/D59509

Comment 20

[:Gijs (he/him)]

(In reply to Dão Gottwald [::dao] from comment #19)

needinfo for gijs to file a followup for https://phabricator.services.mozilla.com/D59509

Filed bug 1609413.

Comment 21

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Reproduced the issue with 74.0a1 (20200109213942) on Windows 10x64 and STR from comment 5.
The issue is verified fixed with Firefox 74.0b5 (20200218224219) on Windows 10x64, macOS 10.15 and Ubuntu 16.04. The pinned tabs are not lost after restart if the first one is selected.