1607441 - Pinned tabs order are reversed every time Nightly is restarted

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect, P1)

Description

[Fanolian]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:74.0) Gecko/20100101 Firefox/74.0
Build ID: 20200107095722

Steps to reproduce

1. In a new profile, pin 2 or more tabs, preferably with different favicons to differentiate them easier.
2. Restart, or close & reopen Nightly.

Actual result

Order for pinned tabs are reversed.

Expected result

Order remains unchanged.

This is regressed by bug 1242912. Is bug 1606633 related?

Comment 1

[Fanolian]

[Tracking Requested - why for this release]:

Comment 2

[:Gijs (he/him)]

Thanks for filing this.

(In reply to Fanolian from comment #0)

This is regressed by bug 1242912. Is bug 1606633 related?

No, that bug is just about the performance of pinned tabs. Because of how pinning works, pinned tabs get inserted immediately, whereas all the other tabs get inserted as a single document fragment. bug 1606633 is about doing the same with pinned tabs, which was hairy because of the implementation of pinning.

This is a pretty odd bug as they come; we pin tabs in the order in which they come in, so I'm not sure where the order gets reversed... Emma, can you take a look?

Comment 3

[:gerard-majax]

This started right with today's update for me: 20200107095722

Comment 4

[B.J. Herbison]

User Agent Mozilla/5.0 (X11; Linux x86_64; rv:74.0) Gecko/20100101 Firefox/74.0

I've had four starts with 20200107095722 and each time the pinned tab order reversed.

For those who don't see the issue, what is your configuration? This doesn't seem to be OS related as the original reporter is on Windows and I'm using Ubuntu.

Comment 5

[:Gijs (he/him)]

(In reply to B.J. Herbison from comment #4)

For those who don't see the issue, what is your configuration?

Nobody on this bug has suggested they cannot reproduce.

Comment 6

[Emma Malysz]

Attachment: Bug 1607441, ensure pinned tabs order is correct by updating their position attribute

Comment 7

[Thomas Brunnthaler]

Hello. I have the same problem every restart since FF 74.0a1 (Win). Pinned tabs are reordered every restart. Please fix as pinned tabs are great to work with. Thank you.

Comment 8

[Julien Cristau [:jcristau] (back April 22)]

Can we land a test for this?

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7109d6215ce1
ensure pinned tabs order is correct by updating their position attribute r=Gijs

Comment 10

[:Gijs (he/him)]

(In reply to Julien Cristau [:jcristau] from comment #8)

Can we land a test for this?

We should, but let's do it in a follow-up. Given Emma and I are 8 timezones apart another review cycle would delay fixing this on nightly.

Comment 11

[B.J. Herbison]

(In reply to :Gijs (he/him) from comment #10)

(In reply to Julien Cristau [:jcristau] from comment #8)

Can we land a test for this?

We should, but let's do it in a follow-up. Given Emma and I are 8 timezones apart another review cycle would delay fixing this on nightly.

Nightly has been my primary browser for years and I put up with minor annoyances to help improve Firefox. For this fix (and almost anything other than a crash or major usability problem) I'd rather wait a day and have a new or improved test included with the fix. I have no doubt about your intentions, but sometimes a "follow-up" can drift into the pile of unfixed work.

Comment 12

[:Gijs (he/him)]

(In reply to B.J. Herbison from comment #11)

(In reply to :Gijs (he/him) from comment #10)

(In reply to Julien Cristau [:jcristau] from comment #8)

Can we land a test for this?

We should, but let's do it in a follow-up. Given Emma and I are 8 timezones apart another review cycle would delay fixing this on nightly.

Nightly has been my primary browser for years and I put up with minor annoyances to help improve Firefox. For this fix (and almost anything other than a crash or major usability problem) I'd rather wait a day and have a new or improved test included with the fix.

I appreciate the vote of confidence.

I have no doubt about your intentions, but sometimes a "follow-up" can drift into the pile of unfixed work.

I'm writing the test right now. :-)

Comment 13

[Dão Gottwald [:dao]]

(In reply to B.J. Herbison from comment #11)

(In reply to :Gijs (he/him) from comment #10)

(In reply to Julien Cristau [:jcristau] from comment #8)

Can we land a test for this?

We should, but let's do it in a follow-up. Given Emma and I are 8 timezones apart another review cycle would delay fixing this on nightly.

Nightly has been my primary browser for years and I put up with minor annoyances to help improve Firefox. For this fix (and almost anything other than a crash or major usability problem) I'd rather wait a day and have a new or improved test included with the fix. I have no doubt about your intentions, but sometimes a "follow-up" can drift into the pile of unfixed work.

I disagree, this bug is hugely annoying for me and gets in the way of getting work done. Thanks for landing the fix asap.

Comment 14

[zak.mcgregor]

Just to confirm that it happens for me, 3 times now. Reversing the reversed pinned tabs made it appear correct, but the latest restart reversed them again.

74.0a1 (2020-01-08) (64-bit) on Fedora 28.

Comment 15

[:Gijs (he/him)]

(In reply to zak.mcgregor from comment #14)

Just to confirm that it happens for me, 3 times now. Reversing the reversed pinned tabs made it appear correct, but the latest restart reversed them again.

74.0a1 (2020-01-08) (64-bit) on Fedora 28.

A fix is already on autoland and, all being well, will be in tonight's nightly (approx. 8-10 hours from now). Please do not leave more "I see this too" comments.

Comment 16

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/7109d6215ce1

Comment 17

[Caspy7]

Possibly related, but I just updated and all my pinned tabs were gone except for the previously focused one.

Comment 18

[Emma Malysz]

Attachment: Bug 1607441, reverse the order of pinned tabs to return back to correct order

Comment 19

[Gian-Carlo Pascutto [:gcp]]

Possibly related, but I just updated and all my pinned tabs were gone except for the previously focused one.

Reported from many places, instead of fixing things this is a dataloss bug now. Filed the new regression as bug 1608036.

Comment 20

[Henrik Skupin [:whimboo][⌚️UTC+1]]

It would be great to also get a test for this particular situation. As it looks like it would have to be a Marionette one given that a restart is involved, right?

Comment 21

[:Gijs (he/him)]

(In reply to Henrik Skupin (:whimboo) [⌚️UTC+1] from comment #20)

It would be great to also get a test for this particular situation. As it looks like it would have to be a Marionette one given that a restart is involved, right?

No, we can test session store without restarting, and a test is already in the dep bug and has r+, but there's room for more tests so I haven't landed it yet - I'm also more concerned with the regressions about losing pinned tabs on nightly right now.

Comment 22

[Cristian Fogel [:cfogel]]

Confirmed issue with 74.0a1 (2020-01-07) on Windows10.
Fix verified with 74.0b4 on Windows 10, macOS 10.13, Ubuntu 18.04.