Strip debug info in Windows ccov build
Categories
(Testing :: Code Coverage, enhancement)
Tracking
(firefox74 fixed)
| Tracking | Status | |
|---|---|---|
| firefox74 | --- | fixed |
People
(Reporter: marco, Assigned: marco)
References
(Depends on 1 open bug, Blocks 1 open bug)
Details
Attachments
(1 file)
Like we are doing for the Linux build (https://hg.mozilla.org/mozilla-central/rev/5f6fd031d3a6), we can use ac_add_options --enable-debug-symbols=-g1.
The savings are smaller than for the Linux build: the symbol files shrink from ~338 MB to ~165 MB, the zip file containing the symbols shrinks from ~71 MB to ~19 MB.
|
Assignee | |
Comment 1•5 years ago
|
||
Depends on D59707
|
||
Updated•5 years ago
|
|
|
||
Updated•5 years ago
|
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
Did this change have the intended effect? In recent Windows ccov build logs I see several thousand instances of
clang: warning: unknown argument ignored in clang-cl: '-g1' [-Wunknown-argument]
Are the symbol file sizes still what you'd expect?
|
|
Assignee | |
Comment 5•4 years ago
|
||
Unfortunately I don't remember what the size was before/after the change. Do we track artifact sizes somewhere?
(In reply to Marco Castelluccio [:marco] from comment #5)
Unfortunately I don't remember what the size was before/after the change. Do we track artifact sizes somewhere?
For binaries yes, but I don't think we track sizes of the symbol file.
I tried rewriting the flag to -clang:-g1 which makes clang-cl accept it, but the symbol files got 3x larger! Same when I used -gline-tables-only which is what I believe -g1 is an alias for.
So -g1 as written doesn't do anything, but removing it altogether also makes things worse, because then the build system fills in the default of -Z7.
At this point I don't know what else to do, and the benefit is outweighing the time spent on it. Probably I will just walk away and pretend I didn't see these warnings.
Description
•