1608146 - toolkit\crashreporter\tools\unit-symbolstore.py::TestFunctional::testSymbolstore fails on Clang coverage build

Status: NEW

(Testing :: Code Coverage, defect, P3)

Description

[Marco Castelluccio [:marco]]

Perhaps it is failing because of this option https://searchfox.org/mozilla-central/rev/be7d1f2d52dd9474ca2df145190a817614c924e4/browser/config/mozconfigs/linux64/code-coverage-opt#3?

Should we disable the test on ccov builds?

The test is passing on Windows Clang, but that's a debug build and doesn't have that option.

Comment 1

[Gabriele Svelto [:gsvelto]]

That test should work in all configurations, do you have a log of the failure?

Comment 2

[Marco Castelluccio [:marco]]

Here it is: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=275427166&repo=try&lineNumber=45655.

Comment 3

[Marco Castelluccio [:marco]]

Attachment: live_backing.tar.xz

I'm attaching the logs from Taskcluster, as they will expire at some point.

Comment 4

[Marco Castelluccio [:marco]]

Another interesting point: a Clang Windows opt build with ac_add_options --enable-debug-symbols=-g1 fails. The same, without ac_add_options --enable-debug-symbols=-g1, doesn't fail.

Comment 5

[Gabriele Svelto [:gsvelto]]

It seems like we're not getting the output we expect, see here:

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=275427166&repo=try&lineNumber=45707

This is the assertion that's failing:

https://searchfox.org/mozilla-central/rev/ba4fab1cc2f1c9c4e07cdb71542b8d441707c577/toolkit/crashreporter/tools/unit-symbolstore.py#524-525

Looking at clang's manual it seems that --enable-debug-symbols=-g1 disables the output of file entries in the debug information so it makes sense that we don't find a FILE entry in the output:

https://clang.llvm.org/docs/ClangCommandLineReference.html#cmdoption-clang-gline-tables-only

-gline-tables-only, -g1, -gmlt

Emit debug line number tables only

Is there a specific reason why we're using -g1 in these builds? If it's a requirement then I'm afraid we have to disable the test, or adjust it to cope with this configuration.

Comment 6

[Marco Castelluccio [:marco]]

The ccov binaries with full debug info were huge, so we are using this option to reduce their size. See bug 1484073 comment 4.

Comment 7

[Gabriele Svelto [:gsvelto]]

Just out of curiosity, what is the default level of --enable-debug-symbols? Anyway we'll need to fix the test.

Comment 8

[Marco Castelluccio [:marco]]

The default seems to be -g for Linux, -Z7 for Windows: https://searchfox.org/mozilla-central/rev/ba4fab1cc2f1c9c4e07cdb71542b8d441707c577/build/moz.configure/toolchain.configure#1214-1221.

Comment 9

[Marco Castelluccio [:marco]]

Attachment: Bug 1608146 - Disable testSymbolstore on code coverage builds. r=gsvelto

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e9e25da01ac7
Disable testSymbolstore on code coverage builds. r=gsvelto

Comment 11

[Marco Castelluccio [:marco]]

Oh, come on...

Comment 12

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/e9e25da01ac7

Comment 13

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:ekyle, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 14

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:marco, maybe it's time to close this bug?

Comment 15

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:marco, maybe it's time to close this bug?

Comment 16

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:marco, maybe it's time to close this bug?

Comment 17

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:marco, maybe it's time to close this bug?
For more information, please visit auto_nag documentation.