1608500 - SharedSurfaceType::Basic not supported for WebVR on Android

Status: RESOLVED FIXED

(Core :: WebVR, defect, P1)

Description

[Imanol Fernandez]

After updating to the latest Gecko WebVR stopped working in Firefox Reality and we see this error in the console.

SharedSurfaceType::Basic not supported for WebVR

I think it's related to Bug 1477756 (it worked well on the Gecko build from two days ago)

Jeff: Do you think it's related? If so, is there any possible fix?

Comment 1

[Kelsey Gilbert [:jgilbert]]

Probably. Are there tests for this?

Comment 2

[Randall Barker [:rbarker]]

We don't have tests partially because we aren't able to run WebGL in the android emulator.

Comment 3

[Kelsey Gilbert [:jgilbert]]

We run WebGL tests on android-hw bots. Is that an option?

Comment 4

[Kelsey Gilbert [:jgilbert]]

This seems suspicious:
https://searchfox.org/mozilla-central/rev/d4d6f81e0ab479cde192453bae83d5e3edfb39d6/dom/canvas/WebGLContext.cpp#995

Comment 5

[:kip (Kearwood Gilbert)]

I can do some tests with Android Firefox Reality on Monday. I saw the Bug 1477756 land today and am reviewing the changes to see what impact this would have on WebVR while rebasing my Bug 1419190 (WebXR) patch.

Comment 6

[:kip (Kearwood Gilbert)]

(In reply to Jeff Gilbert [:jgilbert] from comment #3)

We run WebGL tests on android-hw bots. Is that an option?

What is missing to automate this is a kind of GeckoView-WebVR test runner container. I have some ideas on how such a thing might be made, and would like to build it after WebXR lands if it proves useful.

Comment 7

[Kelsey Gilbert [:jgilbert]]

This asserts for me on GeckoView DEBUG builds:
https://webvr.info/samples/03-vr-presentation.html
Assert: https://searchfox.org/mozilla-central/source/gfx/layers/wr/WebRenderTextureHost.cpp#32

Seems like old code though?

Comment 8

[Imanol Fernandez]

We are not using WebRender yet in FxR. We have this preference set: gfx.webrender.force-disabled false

Comment 9

[Randall Barker [:rbarker]]

(In reply to Imanol Fernandez from comment #8)

We are not using WebRender yet in FxR. We have this preference set: gfx.webrender.force-disabled false

It's actually set to true. That was probably a typo.

Comment 10

[Imanol Fernandez]

yes, it's actually set to true in Firefox Reality (Webrender disabled), it was a typo when I copied the pref name.

Comment 11

[Imanol Fernandez]

I confirmed it's a regression from Bug 1477756

It works well on the commit before Bug 1477756 and fails after applying the patches

Comment 12

[Randall Barker [:rbarker]]

This issue is blocking FxR from moving to newer versions of GeckoView, in fact we are pinned to a single version of GV right now. If it can not be fixed immediately the breaking patch should probably be backed out.

Comment 13

[Imanol Fernandez]

Attachment: Bug 1608500 - Set SurfaceTexture factory into the VR GLScreenBuffer.

The VR ScreenBuffer is created with the default SurfaceFactory_Basic. We need to morph the screen to use the correct SurfaceTexture factory.

Comment 14

[Imanol Fernandez]

https://phabricator.services.mozilla.com/D60007

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9bbd18740388
Set SurfaceTexture factory into the VR GLScreenBuffer. r=jgilbert

Comment 16

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/9bbd18740388