1608521 - Update MediaManager::GetUserMedia for Fission

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, task, P1)

Description

[Nika Layzell [:nika] (ni? for response)]

The IsFullyActive check performed by this method walks up the docshell tree by accessing the embedding <iframe> element recursively. This should be changed to be compatible with fission, where embedding elements and documents may not be available. https://searchfox.org/mozilla-central/rev/d4d6f81e0ab479cde192453bae83d5e3edfb39d6/dom/media/MediaManager.cpp#2215-2241

The only caller already appears to return a MozPromise, which should make converting this check to be async relatively straightforward.

Comment 1

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

:jib, would it make sense for this to live in WebRTC: Audio/Video?

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The component has been changed since the backlog priority was decided, so we're resetting it.
For more information, please visit auto_nag documentation.

Comment 3

[Chris Peterson [:cpeterson]]

Tentatively moving P1 Fission M6 bugs to M6a.

Comment 4

[Chris Peterson [:cpeterson]]

Anny, will you still be working on this WebRTC bug now that you may be taking on more DocumentChannel work? Should we delegate this bug to the WebRTC team?

Comment 5

[Anny Gakhokidze [:annyG]]

I actually have the code written up, I have a few test failures and need to write a test to test some edge cases. I was planning on finishing this up after I fix bug 1630323. I will upload my patch in the meanwhile as WIP.

Comment 6

[Anny Gakhokidze [:annyG]]

Attachment: Bug 1608521 - WIP make IsFullyActive fission compatible

Comment 7

[Anny Gakhokidze [:annyG]]

Attachment: Bug 1608521 - Change mozilla::IsFullyActive to walk WindowContext tree, r=kmag!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d5c3fddbbfe4
Change mozilla::IsFullyActive to walk WindowContext tree, r=kmag

Comment 9

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/d5c3fddbbfe4