1608556 - Expose to privileged JS an API to add markers with a start time and an associated text

Status: RESOLVED FIXED

(Core :: Gecko Profiler, enhancement, P3)

Description

[Nick Alexander :nalexander [he/him]]

Bug 773428 added Services.profiler.AddMarker, but there's no support for including a start time for such markers. This ticket tracks adding API support for such time stamps.

The piece that's not clear to me is how, from privileged JS, one gets an unfuzzed timestamp of the type that AddMarker expects.

Comment 1

[Florian Quèze [:florian]]

Attachment: Bug 1608556 - Expose to privileged JS an API to add markers with a start time and an associated text, r=gerald,mconley.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/859ae92f4110
Expose to privileged JS an API to add markers with a start time and an associated text, r=gerald,mconley,baku.

Comment 3

[Narcis Beleuzu [:NarcisB]]

Backed out for bustages on ProfilerMarkerPayload.h.

Backout link: https://hg.mozilla.org/integration/autoland/rev/b1a9655f50e3d780c72463f89a21c1aa0a9c80c2
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=296173820&repo=autoland&lineNumber=17597

Comment 4

[Florian Quèze [:florian]]

(In reply to Narcis Beleuzu [:NarcisB] from comment #3)

Backed out for bustages on ProfilerMarkerPayload.h.

Sorry, I don't understand why this built fine locally and then failed on all platforms on autoland :-/.

I pushed to try the new version, it built fine, and I verified the profiles contain the expected markers: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6d21bff3ad1c566c1889ad2f04ff3dec51272fa5 (the oranges are intended; to force profile uploads).

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d6d95fa44ebd
Expose to privileged JS an API to add markers with a start time and an associated text, r=gerald,mconley,baku.

Comment 6

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/d6d95fa44ebd