Closed
Bug 1647238
Opened 5 years ago
Closed 5 years ago
Replace Services.profiler.AddMarker with ChromeUtils.addProfilerMarker in browser/
Categories
(Firefox :: General, task, P3)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 79
| Tracking | Status | |
|---|---|---|
| firefox79 | --- | fixed |
People
(Reporter: florian, Assigned: florian)
References
Details
Attachments
(1 file)
The old pattern:
if (Services.profiler) {
Services.profiler.AddMarker("markerName");
}
Can be replaced with the new simpler ChromeUtils.addProfilerMarker("markerName");
Severity: -- → N/A
Priority: -- → P3
|
Assignee | |
Comment 1•5 years ago
|
||
Calls to the old AddMarker API are in browser/ and in talos. I'll make this bug be about the browser/ callers and file another bug for the talos cases; there might be opportunities to make the talos markers more useful (it's currently adding "Start of test" / "End of test" marker pairs, we could likely change that to a single markers with durations).
|
|
Assignee | |
Comment 2•5 years ago
|
||
Depends on D80651
|
||
Updated•5 years ago
|
Assignee: nobody → florian
Status: NEW → ASSIGNED
Pushed by fqueze@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/aef6b831ccbb
Replace Services.profiler.AddMarker with ChromeUtils.addProfilerMarker in browser/, r=Gijs.
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox79:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla79
|
|
Assignee | |
Updated•5 years ago
|
Component: Gecko Profiler → General
Product: Core → Firefox
Summary: Replace Services.profiler.AddMarker with ChromeUtils.addProfilerMarker → Replace Services.profiler.AddMarker with ChromeUtils.addProfilerMarker in browser/
Target Milestone: mozilla79 → Firefox 79
You need to log in
before you can comment on or make changes to this bug.
Description
•