Closed Bug 1608638 Opened 4 years ago Closed 4 years ago

Perma Beta TEST-UNEXPECTED-FAIL | browser/base/content/test/performance/browser_urlbar_keyed_search.js | unexpected changed rect: ({x1:252, x2:291, y1:57, y2:66, w:40, h:10}), window width: 1280 - when Gecko merges to Beta on 2020-02-10

Categories

(Firefox :: Address Bar, defect, P1)

Product:
Firefox
Component:
Address Bar
Type:
defect
Points:
2

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 74
Iteration:
74.1 - Jan 6 - Jan 19
Tracking Flags:
Tracking Status
firefox-esr68 --- unaffected
firefox72 --- unaffected
firefox73 --- unaffected
firefox74 + verified

People

(Reporter: malexandru, Assigned: bugzilla)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file, 1 obsolete file)

Bug 1608638 - Apply a floor and ceiling to Urlbar position values in performance/head.js.
47 bytes, text/x-phabricator-request
Details | Review

Central as Beta simulation: https://treeherder.mozilla.org/#/jobs?repo=try&revision=291a9ff0d936e01cac4631a3846283cb97cb40ef&searchStr=windows%2C10%2Cx64%2Cdevedition%2Copt%2Cmochitests%2Ctest-windows10-64-devedition%2Fopt-mochitest-browser-chrome-e10s-2%2Cm%28bc2%29&selectedJob=284538744

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=284538700&repo=try&lineNumber=2321

[task 2020-01-11T13:47:17.027Z] 13:47:17 INFO - TEST-PASS | browser/base/content/test/performance/browser_urlbar_keyed_search.js | 0 unexpected reflows - true == true -
[task 2020-01-11T13:47:17.027Z] 13:47:17 INFO - comparing 7 frames
[task 2020-01-11T13:47:17.027Z] 13:47:17 INFO - Buffered messages finished
[task 2020-01-11T13:47:17.027Z] 13:47:17 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/performance/browser_urlbar_keyed_search.js | unexpected changed rect: ({x1:252, x2:291, y1:57, y2:66, w:40, h:10}), window width: 1280 -
[task 2020-01-11T13:47:17.027Z] 13:47:17 INFO - Stack trace:
[task 2020-01-11T13:47:17.027Z] 13:47:17 INFO - chrome://mochikit/content/browser-test.js:test_ok:1292
[task 2020-01-11T13:47:17.027Z] 13:47:17 INFO - chrome://mochitests/content/browser/browser/base/content/test/performance/head.js:reportUnexpectedFlicker/rects<:623
[task 2020-01-11T13:47:17.027Z] 13:47:17 INFO - chrome://mochitests/content/browser/browser/base/content/test/performance/head.js:reportUnexpectedFlicker:614
[task 2020-01-11T13:47:17.027Z] 13:47:17 INFO - chrome://mochitests/content/browser/browser/base/content/test/performance/head.js:withPerfObserver:683
[task 2020-01-11T13:47:17.027Z] 13:47:17 INFO - chrome://mochitests/content/browser/browser/base/content/test/performance/head.js:runUrlbarTest:819
[task 2020-01-11T13:47:17.027Z] 13:47:17 INFO - chrome://mochitests/content/browser/browser/base/content/test/performance/browser_urlbar_keyed_search.js:quantumbar:22
[task 2020-01-11T13:47:17.027Z] 13:47:17 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1062
[task 2020-01-11T13:47:17.028Z] 13:47:17 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1097
[task 2020-01-11T13:47:17.028Z] 13:47:17 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:925
[task 2020-01-11T13:47:17.028Z] 13:47:17 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:808
[task 2020-01-11T13:47:17.030Z] 13:47:17 INFO - data:image/png;base64
[task 2020-01-11T13:47:17.041Z] 13:47:17 INFO - data:image/png;base64
[task 2020-01-11T13:47:17.186Z] 13:47:17 INFO - Not taking screenshot here: see the one that was previously logged
[task 2020-01-11T13:47:17.186Z] 13:47:17 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/performance/browser_urlbar_keyed_search.js | should have 0 unknown flickering areas - Got 1, expected 0
[task 2020-01-11T13:47:17.186Z] 13:47:17 INFO - Stack trace:
[task 2020-01-11T13:47:17.186Z] 13:47:17 INFO - chrome://mochikit/content/browser-test.js:test_is:1320
[task 2020-01-11T13:47:17.186Z] 13:47:17 INFO - chrome://mochitests/content/browser/browser/base/content/test/performance/head.js:reportUnexpectedFlicker:640
[task 2020-01-11T13:47:17.186Z] 13:47:17 INFO - chrome://mochitests/content/browser/browser/base/content/test/performance/head.js:withPerfObserver:683
[task 2020-01-11T13:47:17.186Z] 13:47:17 INFO - chrome://mochitests/content/browser/browser/base/content/test/performance/head.js:runUrlbarTest:819
[task 2020-01-11T13:47:17.186Z] 13:47:17 INFO - chrome://mochitests/content/browser/browser/base/content/test/performance/browser_urlbar_keyed_search.js:quantumbar:22
[task 2020-01-11T13:47:17.186Z] 13:47:17 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1062
[task 2020-01-11T13:47:17.186Z] 13:47:17 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1097
[task 2020-01-11T13:47:17.186Z] 13:47:17 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:925
[task 2020-01-11T13:47:17.186Z] 13:47:17 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:808
[task 2020-01-11T13:47:17.186Z] 13:47:17 INFO - Second opening
[task 2020-01-11T13:47:18.935Z] 13:47:18 INFO - TEST-PASS | browser/base/content/test/performance/browser_urlbar_keyed_search.js | 0 unexpected reflows - true == true -

Harry,
Could this be caused by the changes in Bug 1601334?

Flags: needinfo?(htwyford)

This didn't fail in Sunday's early and late beta simulations.

tracking-firefox74: ? → ---

Bugbug thinks this bug is a regression, but please revert this change in case of error.

Keywords: regression

Yes, this is probably caused by Bug 1601334. I'll investigate.

Assignee: nobody → htwyford
Status: NEW → ASSIGNED
Flags: needinfo?(htwyford)

I'm less sure of the exact cause of this now. I was dealing with some intermittent browser_urlbar_keyed_search.js failures when I was working on bug 1601334 but the area of the changed rect was different. Plus (I thought) I resolved that particular failure. This one is less clear, and it's not clear what's flickering by looking at the screenshots. I'm going to attach a patch -- could it please be included in the next beta-sim? It's not really a fix but it'll allow me to better diagnose the problem.

Priority: -- → P1
Attachment #9120623 - Attachment is obsolete: true

I've posted a new patch with a potential fix. It also has a bit of diagnostic code to help my investigation if the fix doesn't work. Could it please be run in the next beta-sim?

Flags: needinfo?(aryx.bugmail)

Thank you for checking. I put a polished version of the patch up for review.

Flags: needinfo?(htwyford)
Iteration: --- → 74.1 - Jan 6 - Jan 19
Points: --- → 2
Attachment #9120893 - Attachment description: Bug 1608638 - Apply a floor and ceiling to l/r Urlbar position values in performance/head.js. → Bug 1608638 - Apply a floor and ceiling to Urlbar position values in performance/head.js.
Pushed by htwyford@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bff9ad0c95ee
Apply a floor and ceiling to Urlbar position values in performance/head.js. r=dao

https://hg.mozilla.org/mozilla-central/rev/bff9ad0c95ee

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox74: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 74
Regressed by: 1601334
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: