[sync] L10n files not imported
Categories
(Webtools Graveyard :: Pontoon, defect, P1)
Tracking
(Not tracked)
People
(Reporter: mathjazz, Assigned: mathjazz)
Details
Attachments
(2 files)
Sync failed to import translations during the Fluent migration ran on Fri, 10 Jan 2020:
- Sync Log
- Migration in source repository
- Migration in l10n repository: example
- Papertrail log is attached
What happened?
- Line 229 in the log properly identified the migrated file in the list of changed paths in repository (and Pontoon) with their corresponding locales:
Jan 10 11:10:49 mozilla-pontoon app/worker.1
Changed files in Firefox repository and Pontoon:
{u'browser/browser/browser.ftl': [<Locale: Acholi>, <Locale: Afrikaans>...]}
- The following line (230) OTOH no longer listed the file among relative paths that need to be synced:
Jan 10 11:10:51 mozilla-pontoon app/worker.1
Changed files in Firefox repository: []
-
The code execute between those lines is in the VCSProject.resources() method, which loops all resource paths of the project (VCSProject.relative_resource_paths()) and checks if they need to be synced.
-
It's likely that no resource paths were found, because VCSProject.source_directory_path was empty. Why? Because another sync task just started running for the Firefox project, syncing source files, and it just removed the source repository, before cloning it.
What needs to be fixed?
-
Prevent multiple sync tasks to run concurrently for the same project. We actually have a mechanism in place to do that (see
RuntimeError
line 735 of the log), but separately for each of the two sync tasks. On a long term, we should join both tasks into one, which would not only fix this bug, but also bug 1383271 and bug 1406374, and make our code nicer. On a short term, we should use the same lock for both sync tasks of the project. -
We should also look into reverting local changes again and see if we can do that without removing the directory.
Comment 1•4 years ago
|
||
Assignee | ||
Comment 2•4 years ago
|
||
Assignee | ||
Updated•4 years ago
|
Updated•3 years ago
|
Description
•