160869 - Opening link to already open frameset hoses history

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect)

Description

[Jerry Baker]

2002080304 trunk

Opening a link to a frameset that is already open will completely hose the
frameset history.

STEPS TO REPRODUCE:

1) Open http://www.landlminiatures.com
2) Compose an email to yourself with a link to http://www.landlminiatures.com in
it (so you have something to click). Use File -> Save or Send Later to save it.
3) While the URL from Step 1 is open, go to your saved message and click on the
link.
4) Now click around in the site and use back and forward buttons.

RESULTS:

It appears that all history entries are replaced with the frameset URL instead
of the individual pages in the frameset. Back and forward buttons just load the
parent frameset no matter what should be in the history. If you go five links
into the site and then press the back button, you are taken to the parent
frameset - click four more times for each history entry and each time the parent
frameset is loaded again. Now try the forward button...same thing.

Comment 1

[Jerry Baker]

I should note that this only happens when the link is loaded into the SAME
window that already has the frameset open. If the link opens in a new window or
tab, this bug will not be seen.

Comment 2

[Grey Hodge (jX)]

*** Bug 160933 has been marked as a duplicate of this bug. ***

Comment 3

[Radha on family leave (not reading bugmail)]

This is broken only in the trunk. The branch is behaving fine. 

Comment 4

[Radha on family leave (not reading bugmail)]

You don't have to click twice on the home page to reproduce this. Just visit the
site, click on  food, accessories, furniture, go somewhere else and click back.
You will return to the main home page and not to the subframe you were in.

Comment 5

[Radha on family leave (not reading bugmail)]

*** Bug 160933 has been marked as a duplicate of this bug. ***

Comment 6

[Radha on family leave (not reading bugmail)]

*** Bug 153240 has been marked as a duplicate of this bug. ***

Comment 7

[Radha on family leave (not reading bugmail)]

patch to bug 144301 contributed to this. Although that bug took care of
shift-reload problems, it has broken the situation when the user presses enter
again in the urlbar. 

Comment 8

[Jerry Baker]

Re: Comment #4: I don't see that problem here in Windows XP with 2002080408 trunk

Comment 9

[Cees T.]

WFM, latest build 2002080708 on WinME.

Comment 10

[Jerry Baker]

CT: note that this bug isn't present on the branch, only on the trunk. Which
build do you have?

Comment 11

[Danny Cardonne]

i have build 2002072104 on win98
the bug is there with back/refresh

Comment 12

[Cees T.]

The files from latest and latest-trunk were the same size, so I assume it's the
trunk. How can I tell without remembering where I got the installer?

I'm currently using Mozilla/5.0 (Windows; U; Win 9x 4.90; en-US; rv:1.1b)
Gecko/20020807 from http://ftp.mozilla.org/pub/mozilla/nightly/latest-trunk/ and
both navigating around http://www.landlminiatures.com and bug 153240 comment 7
WFM. The back/forward buttons don't activate at all on http://www.tlc.de though,
my mistake.

Comment 13

[Radha on family leave (not reading bugmail)]

Attachment: patch to docshell

Take care of specific loadTypes instead of letting all subframes inherit
parent's loadType.

Comment 14

[Adam Lock]

Comment on attachment 95649 [details] [diff] [review]
patch to docshell

r=adamlock

Comment 15

[rpotts (gone)]

Comment on attachment 95649 [details] [diff] [review]
patch to docshell

sr=[e-mail]

Comment 16

[Radha on family leave (not reading bugmail)]

Fix checked in.