Closed Bug 1608717 Opened 4 years ago Closed 4 years ago

Support per-tile clip (valid) region for native compositor implementations.

Categories

(Core :: Graphics: WebRender, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla75
Tracking Status
firefox75 --- fixed

People

(Reporter: gw, Assigned: gw)

References

Details

Attachments

(1 file)

No description provided.
Assignee: nobody → gwatson

For Draw (non-native) and CA modes, we include the per-tile
valid rect in the clip rect from the surface.

For DC (non-virtual) mode, a per-tile clip rect is set on the
visual for each tile, separate from the overall clip rect that
is set on the surface visual.

For DC (virtual) mode, the Trim API is used to remove pixels
in the virtual tile area that are outside the valid / clipped
region.

Note: Although the valid rect is now applied in the native
compositors, it's currently only based on the overall picture
cache bounding rect. Thus, with this patch there isn't any
noticeable performance improvement. Once this lands and is
working correctly, the follow up patch to calculate a smaller
valid region per-tile is a small amount of work.

Pushed by gwatson@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/174d5be06caa
Support per-tile clip (valid) region for native compositor implementations. r=sotaro,mstange
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla75

== Change summary for alert #24941 (as of Fri, 14 Feb 2020 12:05:20 GMT) ==

Improvements:

8% glterrain windows10-64-shippable-qr opt e10s stylo 1.76 -> 1.61
8% glterrain windows10-64-shippable-qr opt e10s stylo 1.74 -> 1.61

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=24941

Blocks: 1646066
Regressions: 1663355
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: