1646066 - Improve partial valid rect handling in NativeLayerCA

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, task)

Description

[Markus Stange [:mstange]]

Bug 1608717 implemented partial invalid rects but disabled some assertions in the process. This bug will perform some cleanup on that code (which I promised to Glenn at the time).

Comment 1

[Markus Stange [:mstange]]

Attachment: Bug 1646066 - Make partial valid rects work properly in NativeLayerCA. r=jrmuizel

This moves the clipping responsibility into the layer. It also brings back
assertions that make sure that no invalid content reaches the screen.
On the layer side I'm renaming validRect to displayRect, because at the time
NextSurface* is called, that rect is not yet valid.
This implementation also allows having valid content outside of the display
rect. So, for example, if you grow and shrink the display rect multiple times
but most of the outer parts are transparent, in theory this allows you to paint
the transparent pixels only once rather than every time the display rect
expands.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9b325856ccc0
Make partial valid rects work properly in NativeLayerCA. r=jrmuizel

Comment 3

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/9b325856ccc0