1608802 - Text in permission management list in about:preferences is spread across 2 lines instead of 1

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P1)

Description

[Itiel]

STR:

1. Open about:preferences#privacy
2. Scroll to the Permissions section, see the permission name is in a new line after its icon
3. Same goes to the "Allow Nightly to send technical and interaction data to Mozilla" checkbox in the Data Collection section

Regressed by bug 1606130.

Comment 1

[Itiel]

Attachment: Screenshot

Comment 2

[:Gijs (he/him)]

Attachment: Bug 1608802 - fix permissions alignment in the preferences now that descriptions are not affected by baseline alignment, r?emilio

There are two issues:

• the 'thin' separators added in bug 1381401 . They have width of 0.5em and now they break things onto their own line. We can just remove these.
• whitespace now produces space, making up for some but not all of the 0.5em separation we had before. Let's add some inline-end margin back to address this.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e56e844e8281
fix permissions alignment in the preferences now that descriptions are not affected by baseline alignment, r=emilio

Comment 4

[Itiel]

Gijs, this patch does not seem to address the "Allow Nightly to send technical and interaction data to Mozilla" checkbox issue.
Shall I file a new bug?

Comment 5

[:Gijs (he/him)]

(In reply to Itiel from comment #4)

Gijs, this patch does not seem to address the "Allow Nightly to send technical and interaction data to Mozilla" checkbox issue.
Shall I file a new bug?

Gah, sorry, I missed that in the description. Yes, please clone the bug. Sorry!

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/e56e844e8281

Comment 7

[:Gijs (he/him)]

Oops. I don't think this is on 73; I was confused by the flags on bug 1606130, but we landed a hackier fix for that bug, which means this bug doesn't exist on 73, as far as I can tell. Itiel, can you confirm, just to make sure I'm not missing something else?

Comment 8

[Itiel]

(In reply to :Gijs (he/him) from comment #7)

Oops. I don't think this is on 73; I was confused by the flags on bug 1606130, but we landed a hackier fix for that bug, which means this bug doesn't exist on 73, as far as I can tell. Itiel, can you confirm, just to make sure I'm not missing something else?

It is as you said, the issue was introduced in 74.

Comment 9

[Alin Ilea, Desktop Test Engineering]

Reproduced the initial issue using an old Nightly build 74.0a1 (Build id: 20200113093823).
Verified - Fixed in Nightly 74.0a1 (Build id: 20200114094410) and latest Nightly 75.0a1 (Build id: 20200212093201) using Windows 10, Mac OS 10.15 and Ubuntu 18.04.