Closed Bug 1608802 Opened 2 years ago Closed 2 years ago

Text in permission management list in about:preferences is spread across 2 lines instead of 1

Categories

(Firefox :: Preferences, defect, P1)

defect

Tracking

()

VERIFIED FIXED
Firefox 74
Tracking Status
firefox-esr68 --- unaffected
firefox72 --- unaffected
firefox73 --- unaffected
firefox74 --- verified

People

(Reporter: itiel_yn8, Assigned: Gijs)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

STR:

  1. Open about:preferences#privacy
  2. Scroll to the Permissions section, see the permission name is in a new line after its icon
  3. Same goes to the "Allow Nightly to send technical and interaction data to Mozilla" checkbox in the Data Collection section

Regressed by bug 1606130.

Flags: needinfo?(emilio)
Attached image Screenshot
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Flags: needinfo?(emilio)

There are two issues:

  • the 'thin' separators added in bug 1381401 . They have width of 0.5em and now they break things onto their own line. We can just remove these.
  • whitespace now produces space, making up for some but not all of the 0.5em separation we had before. Let's add some inline-end margin back to address this.
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/e56e844e8281
fix permissions alignment in the preferences now that descriptions are not affected by baseline alignment, r=emilio

Gijs, this patch does not seem to address the "Allow Nightly to send technical and interaction data to Mozilla" checkbox issue.
Shall I file a new bug?

Flags: needinfo?(gijskruitbosch+bugs)

(In reply to Itiel from comment #4)

Gijs, this patch does not seem to address the "Allow Nightly to send technical and interaction data to Mozilla" checkbox issue.
Shall I file a new bug?

Gah, sorry, I missed that in the description. Yes, please clone the bug. Sorry!

Flags: needinfo?(gijskruitbosch+bugs) → needinfo?(itiel_yn8)
Blocks: 1608829
Flags: needinfo?(itiel_yn8)
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 74
Summary: Some text in about:preferences is spread across 2 lines instead of 1 → Text in permission management list in about:preferences is spread across 2 lines instead of 1

Oops. I don't think this is on 73; I was confused by the flags on bug 1606130, but we landed a hackier fix for that bug, which means this bug doesn't exist on 73, as far as I can tell. Itiel, can you confirm, just to make sure I'm not missing something else?

Flags: needinfo?(itiel_yn8)

(In reply to :Gijs (he/him) from comment #7)

Oops. I don't think this is on 73; I was confused by the flags on bug 1606130, but we landed a hackier fix for that bug, which means this bug doesn't exist on 73, as far as I can tell. Itiel, can you confirm, just to make sure I'm not missing something else?

It is as you said, the issue was introduced in 74.

Flags: needinfo?(itiel_yn8)

Reproduced the initial issue using an old Nightly build 74.0a1 (Build id: 20200113093823).
Verified - Fixed in Nightly 74.0a1 (Build id: 20200114094410) and latest Nightly 75.0a1 (Build id: 20200212093201) using Windows 10, Mac OS 10.15 and Ubuntu 18.04.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.