use the new certificate viewer in thunderbird (about:certificate?cert=)
Categories
(Thunderbird :: Security, enhancement, P1)
Tracking
(Not tracked)
People
(Reporter: keeler, Assigned: khushil324)
References
(Blocks 1 open bug)
Details
Attachments
(2 files, 3 obsolete files)
The new certificate viewer (see bug 1553524) shipped in Firefox 71. Thunderbird should switch over to using it so the old implementation can be removed.
From what I can tell, the old implementation is referenced in two places:
https://searchfox.org/comm-central/rev/87456630f1a92870f0c03a404def84207ef50c95/mailnews/extensions/smime/content/msgReadSecurityInfo.js#219
https://searchfox.org/comm-central/rev/87456630f1a92870f0c03a404def84207ef50c95/mailnews/extensions/smime/content/msgCompSecurityInfo.js#284
It should be possible to change those along the lines of:
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Assignee | ||
Comment 1•5 years ago
•
|
||
I need some feedback. I have a few questions:
- If you open the certificate, you have two options: PEM(Cert) and PEM(Chain) to download the certificate. It's <html:a> component with href="data;<data>" and when we click, nothing is happening. What do we need to keep in mind while working on the <html:a> in the Thunderbird?
- critcal.svg icon is not loading up. I have tried to override the icon with the messenger one. But it's not loading up. Do we need to take care of anything while overriding?
Comment 2•5 years ago
•
|
||
Assignee | ||
Comment 3•5 years ago
|
||
Assignee | ||
Updated•5 years ago
|
Comment 4•5 years ago
|
||
Assignee | ||
Comment 5•5 years ago
|
||
Comment 6•5 years ago
|
||
Assignee | ||
Comment 7•5 years ago
|
||
This part is coming from the Mozilla Central pippki.js: https://searchfox.org/mozilla-central/source/security/manager/pki/resources/content/pippki.js#33-50
How can we override this part?
Comment 8•5 years ago
|
||
I've got a patch to fix that. Will upload once I got it fully tested.
Comment 9•5 years ago
|
||
Comment 10•5 years ago
|
||
With the mozilla-central patch above we get the right window.
The Thunderbird patch needs to also add handling to open a tab for this case at https://searchfox.org/comm-central/rev/cfa832291ae06d6b814f8a9ebe1991a08f25da92/mail/base/content/contentAreaClick.js#256
Something like
document.getElementById("tabmail").openTab("contentTab", {
contentPage: url,
clickHandler: "specialTabs.aboutClickHandler(event);",
});
``
Assignee | ||
Comment 11•5 years ago
|
||
Assignee | ||
Comment 12•5 years ago
|
||
We have a problem with icon critcal.svg that we need to keep in my mind and ask the M-C developers to change it so that we can override it.
Comment 13•5 years ago
|
||
Comment 14•5 years ago
|
||
bugherder |
Comment 15•5 years ago
|
||
Reopening until we land the Thunderbird part.
Comment 16•5 years ago
|
||
Updated•5 years ago
|
Comment 17•5 years ago
|
||
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/3d86054fed85
use the new certificate viewer in thunderbird (about:certificate?cert=). r=mkmelin
Description
•