Closed Bug 1609069 Opened 4 years ago Closed 4 years ago

Clicking empty area below the categories list navigates back to the main list

Categories

(Toolkit :: Add-ons Manager, defect)

72 Branch
defect
Not set
normal

Tracking

()

VERIFIED FIXED
mozilla74
Tracking Status
firefox-esr68 --- unaffected
firefox72 --- wontfix
firefox73 --- wontfix
firefox74 --- verified

People

(Reporter: ke5trel, Assigned: mstriemer)

References

(Regression)

Details

(Keywords: regression, ux-consistency, ux-control)

Attachments

(2 files)

STR:

  1. Go to about:addons#themes.
  2. Open a theme details page.
  3. Click in the blank area in the sidebar, immediately below the page categories.

Expected:

Nothing.

Actual:

Navigates back to the main list.

This is an invisible clickable region that has an unexpected result. It can cause data loss for extension preferences pages that require clicking a save button before changes are applied.

Regression range:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=628967f53151659cf2666e15d50f37fd80952d9a&tochange=16bc115ecd46ed37ff921ed4273532c16d3b0205

Regressed by Bug 1591501.

Hi Mark, can you please take a look at this when you get a chance?

Flags: needinfo?(mstriemer)
Assignee: nobody → mstriemer
Status: NEW → ASSIGNED
Pushed by mstriemer@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fc5cbea8d173
Avoid switching view when clicking sidebar padding r=rpl

Comment on attachment 9122789 [details]
Bug 1609069 - Avoid switching view when clicking sidebar padding r?rpl

Beta/Release Uplift Approval Request

  • User impact if declined: Clicks on the sidebar padding could change the current view in about:addons.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: See comment 0
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Adds a simple check that the click was on a button.
  • String changes made/needed: No
Flags: needinfo?(mstriemer)
Attachment #9122789 - Flags: approval-mozilla-beta?
Flags: qe-verify+

Not sure if this is worthy of an uplift but it's a small change and I'd be fine with uplifting it if that's wanted.

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
QA Whiteboard: [qa-triaged]

I have reproduced the issue in Nightly v74.0a1 from 2020-01-28 and verified the fix in Nightly v74.0a1 from 2020-01-29 on Windows 10, MacOS 10.13 and Ubuntu 18.04. Awaiting for Beta uplift approval.

Comment on attachment 9122789 [details]
Bug 1609069 - Avoid switching view when clicking sidebar padding r?rpl

I think this can ride to 74.

Attachment #9122789 - Flags: approval-mozilla-beta? → approval-mozilla-beta-

Setting the status flag and removing the "qe-verify+" tag based on the comment above.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: