Clicking empty area below the categories list navigates back to the main list
Categories
(Toolkit :: Add-ons Manager, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr68 | --- | unaffected |
firefox72 | --- | wontfix |
firefox73 | --- | wontfix |
firefox74 | --- | verified |
People
(Reporter: ke5trel, Assigned: mstriemer)
References
(Regression)
Details
(Keywords: regression, ux-consistency, ux-control)
Attachments
(2 files)
31.01 KB,
image/png
|
Details | |
47 bytes,
text/x-phabricator-request
|
jcristau
:
approval-mozilla-beta-
|
Details | Review |
STR:
- Go to
about:addons#themes
. - Open a theme details page.
- Click in the blank area in the sidebar, immediately below the page categories.
Expected:
Nothing.
Actual:
Navigates back to the main list.
This is an invisible clickable region that has an unexpected result. It can cause data loss for extension preferences pages that require clicking a save button before changes are applied.
Regression range:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=628967f53151659cf2666e15d50f37fd80952d9a&tochange=16bc115ecd46ed37ff921ed4273532c16d3b0205
Regressed by Bug 1591501.
Comment 1•4 years ago
|
||
Hi Mark, can you please take a look at this when you get a chance?
Assignee | ||
Comment 2•4 years ago
|
||
Updated•4 years ago
|
Pushed by mstriemer@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fc5cbea8d173 Avoid switching view when clicking sidebar padding r=rpl
Assignee | ||
Comment 4•4 years ago
|
||
Comment on attachment 9122789 [details]
Bug 1609069 - Avoid switching view when clicking sidebar padding r?rpl
Beta/Release Uplift Approval Request
- User impact if declined: Clicks on the sidebar padding could change the current view in about:addons.
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: Yes
- If yes, steps to reproduce: See comment 0
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Adds a simple check that the click was on a button.
- String changes made/needed: No
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 5•4 years ago
|
||
Not sure if this is worthy of an uplift but it's a small change and I'd be fine with uplifting it if that's wanted.
Comment 6•4 years ago
|
||
bugherder |
Updated•4 years ago
|
Comment 7•4 years ago
|
||
I have reproduced the issue in Nightly v74.0a1 from 2020-01-28 and verified the fix in Nightly v74.0a1 from 2020-01-29 on Windows 10, MacOS 10.13 and Ubuntu 18.04. Awaiting for Beta uplift approval.
Comment 8•4 years ago
|
||
Comment on attachment 9122789 [details]
Bug 1609069 - Avoid switching view when clicking sidebar padding r?rpl
I think this can ride to 74.
Updated•4 years ago
|
Comment 9•4 years ago
|
||
Setting the status flag and removing the "qe-verify+" tag based on the comment above.
Updated•4 years ago
|
Description
•