1591501 - Extensions list is not shown when clicking "Extensions" after opening an extension

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect, P3)

Description

[Artem S. Tashkinov]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:70.0) Gecko/20100101 Firefox/70.0

Steps to reproduce:

Right mouse click any extension and click "Manage Extension", then click "Extensions" in a newly opened tab. Firefox will NOT show all extensions. You have to first click any other item like "Themes" and then click "Extensions" again to see all the extensions.

This is quite annoying. Please fix.

Comment 1

[Mark Striemer [:mstriemer]]

It seems that this happens when you click on the text/icon in that button. If you click above or below the text/icon then it works.

We should likely also be showing the back button here too.

Comment 2

[Artem S. Tashkinov]

Attachment: clip.mkv

(In reply to Mark Striemer [:mstriemer] from comment #1)

It seems that this happens when you click on the text/icon in that button. If you click above or below the text/icon then it works.

We should likely also be showing the back button here too.

I'm 100% sure I'm clicking the right place.

Comment 3

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

(In reply to Mark Striemer [:mstriemer] from comment #1)

It seems that this happens when you click on the text/icon in that button. If you click above or below the text/icon then it works.

We should likely also be showing the back button here too.

Back button doesn't show itself with this STR.

Also these errors appears in Browser Console after doing STR:

09:24:46.838 TypeError: global.actionContextMenu is not a function
ext-browserAction.js:408:18
09:24:49.720 Content Security Policy: The page’s settings blocked the loading of a resource at inline (“default-src”). menupopup.js:67:25

Comment 4

[Liz Henry (:lizzard) (relman/hg->git project)]

Too late for a fix in 70. We could still take a patch for 72/71 though.

Comment 5

[Mark Striemer [:mstriemer]]

Attachment: Bug 1591501 - Click category to go back to list in about:addons r?rpl

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/97a383ec65b7
Click category to go back to list in about:addons r=rpl

Comment 7

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f7c199feb6c6
Backed out changeset 97a383ec65b7 for failures at browser_discovery.js on a CLOSED TREE.

Comment 8

[Raul Gurzau (:RaulG)]

Backed out changeset 97a383ec65b7 (bug 1591501) for failures at browser_discovery.js on a CLOSED TREE.

Backout link: https://hg.mozilla.org/integration/autoland/rev/f7c199feb6c60812b4e41ea944f4c13a6b2b80a7

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=97a383ec65b7791c289a1ae523cd7181d3ec6093&selectedJob=276050670

Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=276050670&repo=autoland&lineNumber=16267

Log snippet:
[task 2019-11-13T18:35:10.173Z] 18:35:10 INFO - Console message: [JavaScript Error: "Content Security Policy: The page’s settings blocked the loading of a resource at inline (“default-src”)." {file: "chrome://global/content/elements/menupopup.js" line: 67}]
[task 2019-11-13T18:35:10.173Z] 18:35:10 INFO - window has focus, waiting for manager load
[task 2019-11-13T18:35:10.174Z] 18:35:10 INFO - Manager waiting for view load
[task 2019-11-13T18:35:10.175Z] 18:35:10 INFO - TEST-PASS | toolkit/mozapps/extensions/test/browser/browser_discovery.js | Should have loaded the right url -
[task 2019-11-13T18:35:10.175Z] 18:35:10 INFO - TEST-PASS | toolkit/mozapps/extensions/test/browser/browser_discovery.js | Element should not be null, when checking visibility -
[task 2019-11-13T18:35:10.176Z] 18:35:10 INFO - TEST-PASS | toolkit/mozapps/extensions/test/browser/browser_discovery.js | Loading message should be visible when its panel is the selected panel -
[task 2019-11-13T18:35:10.179Z] 18:35:10 INFO - TEST-PASS | toolkit/mozapps/extensions/test/browser/browser_discovery.js | Clicking link link-good should show the loading pane -
[task 2019-11-13T18:35:10.179Z] 18:35:10 INFO - TEST-PASS | toolkit/mozapps/extensions/test/browser/browser_discovery.js | Should have loaded the right url -
[task 2019-11-13T18:35:10.179Z] 18:35:10 INFO - TEST-PASS | toolkit/mozapps/extensions/test/browser/browser_discovery.js | Should not get category when manager window is not loaded -
[task 2019-11-13T18:35:10.180Z] 18:35:10 INFO - TEST-PASS | toolkit/mozapps/extensions/test/browser/browser_discovery.js | Should not open category when manager window is not loaded -
[task 2019-11-13T18:35:10.180Z] 18:35:10 INFO - TEST-PASS | toolkit/mozapps/extensions/test/browser/browser_discovery.js | Should not check visible state when manager window is not loaded -
[task 2019-11-13T18:35:10.181Z] 18:35:10 INFO - TEST-PASS | toolkit/mozapps/extensions/test/browser/browser_discovery.js | Category should be visible if attempting to open it -
[task 2019-11-13T18:35:10.181Z] 18:35:10 INFO - TEST-PASS | toolkit/mozapps/extensions/test/browser/browser_discovery.js | Should not get category when manager window is not loaded -
[task 2019-11-13T18:35:10.182Z] 18:35:10 INFO - TEST-PASS | toolkit/mozapps/extensions/test/browser/browser_discovery.js | Should not open category when manager window is not loaded -
[task 2019-11-13T18:35:10.183Z] 18:35:10 INFO - TEST-PASS | toolkit/mozapps/extensions/test/browser/browser_discovery.js | Should not check visible state when manager window is not loaded -
[task 2019-11-13T18:35:10.183Z] 18:35:10 INFO - TEST-PASS | toolkit/mozapps/extensions/test/browser/browser_discovery.js | Category should be visible if attempting to open it -
[task 2019-11-13T18:35:10.184Z] 18:35:10 INFO - Buffered messages finished
[task 2019-11-13T18:35:10.184Z] 18:35:10 INFO - TEST-UNEXPECTED-FAIL | toolkit/mozapps/extensions/test/browser/browser_discovery.js | Should have loaded the right url - Got https://example.com/browser/toolkit/mozapps/extensions/test/browser/releaseNotes.xhtml, expected https://example.com/browser/toolkit/mozapps/extensions/test/browser/discovery.html
[task 2019-11-13T18:35:10.186Z] 18:35:10 INFO - Stack trace:
[task 2019-11-13T18:35:10.186Z] 18:35:10 INFO - chrome://mochikit/content/browser-test.js:test_is:1314
[task 2019-11-13T18:35:10.187Z] 18:35:10 INFO - chrome://mochitests/content/browser/toolkit/mozapps/extensions/test/browser/browser_discovery.js:null:371
[task 2019-11-13T18:35:10.187Z] 18:35:10 INFO - chrome://mochitests/content/browser/toolkit/mozapps/extensions/test/browser/head.js:log_exceptions:203
[task 2019-11-13T18:35:10.188Z] 18:35:10 INFO - chrome://mochitests/content/browser/toolkit/mozapps/extensions/test/browser/head.js:run_next_test/<:247
[task 2019-11-13T18:35:10.190Z] 18:35:10 INFO - chrome://mochikit/content/browser-test.js:run:1366

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/16bc115ecd46
Click category to go back to list in about:addons r=rpl

Comment 10

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/16bc115ecd46

Comment 11

[Alex Cornestean]

Hello Mark,

Verified the fix on the latest Nightly (72.0a1/20191118093852) under Windows 10 Pro 64-bit and MacOS Catalina 10.15.

Clicking the “Extensions” category button from the add-on’s detail page (reached by right clicking the add-on icon → ‘Manage Extension’) will properly direct the user to the list view of the Extensions tab, confirming this aspect of the fix.

However after exploring the issue a bit further, several problems have been noticed:

• On Nightly:

1. Performing the STR from a fresh new tab (which will open the detail page of the add-on in the same tab), except not clicking on the “Extensions” category button but on the Back Button, will return the user back to the new tab page
2. After clicking the Back Button once (doing Step 1 from above), the user will be back to the new tab page. Performing the mentioned STR again from the exact same new tab, will open the detail page of the add-on in a new tab and clicking on the Back Button will not work anymore
3. Opening a fresh new tab, loading a random webpage and performing the above STR, will cause the Back Button to not work anymore

For more details, please see the attached “back button issue Nightly” screen recording.

• On Beta and Release:

1. Performing the STR from a fresh new tab (which will open the detail page of the add-on in the same tab), except not clicking on the “Extensions” category button but on the Back Button, will return the user back to the new tab page. NOTE: the Back Button is present and displayed
2. After clicking the Back Button once (doing Step 1 from above), the user will be back to the new tab page. Performing the mentioned STR again from the exact same new tab, will open the detail page of the add-on in a new tab and this time the Back Button is missing
3. Opening a fresh new tab, loading a random webpage and performing the above STR, will cause the Back Button to not be displayed

For more details, please see the attached “back button issue Beta+Release” screen recording.

As the issue with the “Extensions” category button is fixed in the latest Nightly, please let me know if I should close this issue as Verified Fixed and file a new bug regarding the Back Button behavior OR you will track the issue from here.

Comment 12

[Alex Cornestean]

Attachment: back button issues Nightly.gif

Comment 13

[Alex Cornestean]

Attachment: back button issues Beta+Release.gif

Comment 14

[Mark Striemer [:mstriemer]]

The back button not doing anything is bug 1594392.

Comment 15

[Alex Cornestean]

As the issue with the “Extensions” category button is fixed and also taking into consideration the comment above, closing as Verified Fixed.