1609180 - Fullscreen when called from parent iframe not working

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect, P2)

Description

[sonesh.dabhi]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/79.0.3945.117 Safari/537.36

Steps to reproduce:

Open this page https://jinyeng.github.io/HTMLNotificationsChromeBug/
Click on Full Screen button from inside of iframe. It works.
Click on Full Screen button from parent page.

Actual results:

When cliking fullscreen from parent page. It does not enter in to fullscreen.
This works fine in chrome and used to work in previous version of Firefox as well.

Expected results:

It should work in same way when called from parent page full screen button.
This works fine in chrome and used to work in previous version of Firefox as well.

Comment 1

[Daniel Kolsis]

Hello, i managed to reproduce the issue on Firefox 72.0.1, beta 73.0b7, and Nightly 74.0a1 (2020-01-19).
This problem seems to have appeared somewhere in version 71.
Note that the following message is printed in the console when the button is pressed:
"Request for fullscreen was denied because Element.requestFullscreen() was not called from inside a short running user-generated event handler."

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:Dolske, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 3

[:Gijs (out for now; he/him)]

Can you find a regression window?

Comment 4

[Edgar Chen [:edgar]]

I believe it is because of bug 1129227. We probably need bug 1578357 like Chrome does.

Comment 5

[Daniel Kolsis]

Hello, I've done a regression check using mozregression, here are the results:

2020-01-30T17:43:46: INFO : Narrowed inbound regression window from [88bfb2e6, 011193f6] (4 builds) to [b7dd0f12, 011193f6] (2 builds) (~1 steps left)
2020-01-30T17:43:46: DEBUG : Starting merge handling...
2020-01-30T17:43:46: DEBUG : Using url: https://hg.mozilla.org/integration/autoland/json-pushes?changeset=011193f69f2fad43eeb92f597954b52d3e7755e8&full=1
2020-01-30T17:43:48: DEBUG : Found commit message:
Bug 1585519 - Part 4: Remove unnecessary parentheses. r=Yoric CLOSED TREE

Reviewers: Yoric

Subscribers: jandem

Bug #: 1585519

Differential Revision: https://phabricator.services.mozilla.com/D48293

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

edgar: Do you think that the regression range (bug 1585519) is reasonable for your thought?

Comment 7

[Edgar Chen [:edgar]]

(In reply to Masayuki Nakano [:masayuki] (he/him)(JST, +0900) from comment #6)

edgar: Do you think that the regression range (bug 1585519) is reasonable for your thought?

No, this doesn't look like something related to bug 1585519. Bug 1585519 is to add MOZ_LIKELY/MOZ_UNLIKELY, I don't expect it will change fullscreen behavior.

Daniel, could you check again?
Note: please don't interact with iframe during the test, e.g. click, otherwise, the iframe will be considered as user-activated and allow the full-screen request. Which will probably lead to a wrong result. Thanks.

Comment 8

[Daniel Kolsis]

I've repeated the test, this time without interacting with the iframe whatsoever, and did indeed reach a different conclusion.
Just to make sure we're on the same page, my steps were:

1. Reach the page
2. Click the Full Screen Parent Page button

with these steps I've arrived to this build:
DEBUG : Found commit message:
Bug 1129227 - Part 3: Add test for requesting fullscreen in async callback; r=smaug

Differential Revision: https://phabricator.services.mozilla.com/D47152

Comment 9

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

edgar: Could you set proper priority for this bug? Thanks.

Comment 10

[Edgar Chen [:edgar]]

I am working on bug 1578357, I expect it could fix this issue.

Comment 11

[Edgar Chen [:edgar]]

This should be fixed by bug 1578357, but I would like to add a test for fullscreen here.

Comment 12

[Edgar Chen [:edgar]]

Attachment: Bug 1609180 - Add test for requesting fullscreen from parent window;

Comment 13

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=dc859f9fa75ac6d1fbd2249a0fb6594054420c2f&group_state=expanded

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/060b2b69c447
Add test for requesting fullscreen from parent window; r=smaug

Comment 15

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/060b2b69c447

Comment 16

[Daniel Kolsis]

Verified - Fixed - The issue can no longer be reproduced. Checked on MacOS 10.15, Windows 10 and Ubuntu 18.04.