1609268 - Changing WebRender prefs doesn't work live anymore on Mac

Status: VERIFIED FIXED

(Core :: Graphics: WebRender, defect, P3)

Comment 1

[Jeff Muizelaar [:jrmuizel]]

My guess is that this was broken by bug 1592016

Comment 2

[Jeff Muizelaar [:jrmuizel]]

I was wrong. It was actually bug 1600472.

Comment 3

[Bert Peers [:bpeers]]

Do you have a priority in mind for this? Thanks!

Comment 4

[Andrew Osmond [:aosmond] (he/him)]

It looks like this is because CompositorBridgeParent::InitializeStatics() isn't called unless WebRender is in the GPU process. Without that you won't get notifications. I can reproduce by disabling the GPU process on Linux.

Comment 5

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1609268 - Make WebRender debug prefs apply live without the GPU process.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/15fbe779dd30
Make WebRender debug prefs apply live without the GPU process. r=jrmuizel

Comment 7

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/15fbe779dd30

Comment 8

[Rares Doghi, Desktop QA]

Is this issue about the gfx.webrender.all preference on Mac OS ? are there any steps to verify this issue? I'm not sure what Webrender prefs do not work live means because I was able to enable WebRender by setting gfx.webrender.all = true in Release as well.

Comment 9

[Andrew Osmond [:aosmond] (he/him)]

This refers to the gfx.webrender.debug.* prefs in about:config. For example, if you toggle gfx.webrender.debug.picture-caching to true when WebRender is in use, then you should immediately (e.g. live pref) see a multi-coloured overlay showing the picture cache surfaces. On Mac this was broken so you had to restart the browser in order for the prefs to take effect.

Comment 10

[Rares Doghi, Desktop QA]

Thank you for the extra info, This issue is Verified as Fixed in our latest Beta 74.0b5 and Nightly builds.