1609474 - Reading extensions.webextensions.remote once for the purposes of Eval/Js Load Telemetry

Status: RESOLVED FIXED

(WebExtensions :: General, defect)

Description

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

This will avoid sending Telemetry if the pref is enabled during a session.

Comment 1

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Attachment: Bug 1609474 - Handle if extensions.webextensions.remote changes during runtime for the purposes of Eval/JS Load Telemetry r?robwu

Comment 2

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Comment on attachment 9121096 [details]
Bug 1609474 - Handle if extensions.webextensions.remote changes during runtime for the purposes of Eval/JS Load Telemetry r?robwu

Beta/Release Uplift Approval Request

• User impact if declined: We will delay collecting improving our Telemetry collection and will negatively impact a very small percentage of users who do weird non-default things such that their Firefox may behave in unexpected ways.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is a small change that primarily affects an exception case for users who are doing non-standard things.
• String changes made/needed:

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4a5855f72ff4
Handle if extensions.webextensions.remote changes during runtime for the purposes of Eval/JS Load Telemetry r=robwu,ckerschb

Comment 4

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/4a5855f72ff4

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9121096 [details]
Bug 1609474 - Handle if extensions.webextensions.remote changes during runtime for the purposes of Eval/JS Load Telemetry r?robwu

Telemetry improvement for some edge cases. Approved for 73.0b9.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/9fb939d53102

Comment 7

[Miruna Curtean]

Hello.
I see that that in the Beta/Release Uplift Approval Request it has been specified no manual testing is needed. If that is the case do you mind setting the "qe-verify" flag? If not, please provide more details/ steps to test the ticket.
Thank you