1609557 - Migrate placesContextMenu.inc.xhtml to Fluent

Status: VERIFIED FIXED

(Firefox :: General, task, P3)

Description

[Zibi Braniecki [:zbraniecki][:gandalf]]

As part of bug 1579477 we want to migrate https://searchfox.org/mozilla-central/source/browser/components/places/content/placesContextMenu.inc.xhtml to Fluent.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Hey Julian,

There are a lot of strings and items in this context menu. Some of them only display in certain situations, depending on what the context menu is being opened on. It's some pretty sophisticated logic.

You can get most of the items to show if you return early from here: https://searchfox.org/mozilla-central/rev/6cd54550a27e2f6ca0755a25328f769e41e524f4/browser/components/places/content/controller.js#595, and then open up the Library (Cmd-Shift-B), and right-click on a bookmark item.

That should be enough to get you started. There are some tricker menu items manipulated down here: https://searchfox.org/mozilla-central/rev/6cd54550a27e2f6ca0755a25328f769e41e524f4/browser/components/places/content/controller.js#681-702

where they get their strings set depending on how many items are selected. Once you're done your first pass of translations, you can remove the early return at https://searchfox.org/mozilla-central/rev/6cd54550a27e2f6ca0755a25328f769e41e524f4/browser/components/places/content/controller.js#595, and then select a single bookmark, and then multiple bookmarks, to see those variations.

Finally, there's a "Properties" entry that appears to be removed in the Library: https://searchfox.org/mozilla-central/rev/6cd54550a27e2f6ca0755a25328f769e41e524f4/browser/components/places/content/places.js#233-235

If you comment those lines out, you can force it to appear.

Hopefully that's enough information to let you display each variation for the context menu items!

Comment 3

[Julian Shomali]

Attachment: Bug 1609557 - Migrate placesContextMenu.inc.xhtml to Fluent. r=flod,Gijs

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a32a1f5c2676
Migrate placesContextMenu.inc.xhtml to Fluent. r=fluent-reviewers,flod,Gijs

Comment 5

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6331429d8560
Backed out changeset a32a1f5c2676 for causing bc failures.

Comment 6

[Alexandru Michis [:malexandru]]

Backed out changeset a32a1f5c2676 (Bug 1609557) for causing bc failures.

Backout link: https://hg.mozilla.org/integration/autoland/rev/6331429d856033aaf757ebf2863ee36ae2b8a29d

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&collapsedPushes=676749&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&tochange=6331429d856033aaf757ebf2863ee36ae2b8a29d&fromchange=2a11a66d8da75920fc17242905136e32e89a670d&failure_classification_id=2&selectedJob=296565847

Failure logs:

• https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=296567268&repo=autoland&lineNumber=6925
• https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=296567199&repo=autoland&lineNumber=11980
• https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=296565755&repo=autoland&lineNumber=19730

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6b4d325bd6f7
Migrate placesContextMenu.inc.xhtml to Fluent. r=fluent-reviewers,flod,Gijs

Comment 8

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/6b4d325bd6f7

Comment 9

[Anca Soncutean, Desktop QA]

Verified fixed as part of PI 551; tested with Nightly 77 across platforms (Windows 10, macOS 10.15 and Ubuntu 18.04).