1609711 - Compute gradient stop positions in css pixels.

Status: RESOLVED FIXED

(Core :: Graphics, task)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1609711 - Compute gradient positions in css pixels. r=jrmuizel

The gradient code is the only one that does a really weird thing with
LengthPercentage values, by getting the percentage and length separately and
turning the length into a percentage relative to the line length (which is in
device pixels).

This won't work once we have min() / max() / etc. in CSS (as we can't access
the length and percentage components separately, as which one you choose may
depend on the percentage basis). So instead of that, use the regular
ResolveToCssPixels there are lengths involved.

We change a bit the surrounding code to work in CSS pixels, so as to avoid
unneeded CSS -> device pixel conversions.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/627ee9bf5573
Compute gradient positions in css pixels. r=jrmuizel

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1609711 - Fix merge conflict.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2857feeff01b
Fix merge conflict.

Comment 5

[Cosmin Sabou [:CosminS]]

Backed out 2 changesets (Bug 1609711) for causing reftest failures on radial-size-1b.html.

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&tochange=bfd9d64b9973a5b97dc8663c9ea84a1c1557c876&searchStr=reftest&fromchange=627ee9bf55737123a114b3494b769d9eeb0e04d2&selectedJob=286098987

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=286098987&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/bfd9d64b9973a5b97dc8663c9ea84a1c1557c876

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/11fc4b2cfb35
Compute gradient positions in css pixels. r=jrmuizel

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7ae5377fd5fe
Minor fuzz adjustments.

Comment 8

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/11fc4b2cfb35
https://hg.mozilla.org/mozilla-central/rev/7ae5377fd5fe