1609737 - Forbid accessing the length and percentage parts of a LengthPercentage separately.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1609737 - Forbid accessing the length and percentage parts of a LengthPercentage separately. r=#style

This is just not a thing you can do if you have min() / max() / etc, as the min
/ max value may depend on the percentage basis.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1609737 - Simplify calc expressions earlier. r=#style

This simplifies a bit the code, and guarantees that all calc()s have percentages
and lengths.

I also wanted to remove unclamped_length() / specified_percentage() (for the
same reason as the above patch), but they're needed for animations for now. When
I implement min() / max() for <length-percentage> they'll be fixed.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/51f3f1a1efb8
Forbid accessing the length and percentage parts of a LengthPercentage separately. r=boris

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d12980bbc425
Simplify calc expressions earlier. r=boris

Comment 5

[Cosmin Sabou [:CosminS]]

Backed out 2 changesets (bug 1609737) for causing build bustages on nsCSSRenderingGradients after backing out Bug 1609711.

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=286102860&resultStatus=success%2Ctestfailed%2Cbusted%2Cexception&fromchange=bfd9d64b9973a5b97dc8663c9ea84a1c1557c876&tochange=79a03c321f93c2a2456f31a6070f5bf7ce897bcb&searchStr=build

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=286102860&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/79a03c321f93c2a2456f31a6070f5bf7ce897bcb

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6c6d488d79fa
Forbid accessing the length and percentage parts of a LengthPercentage separately. r=boris
https://hg.mozilla.org/integration/autoland/rev/9e5eb3e65f05
Simplify calc expressions earlier. r=boris

Comment 7

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/6c6d488d79fa
https://hg.mozilla.org/mozilla-central/rev/9e5eb3e65f05