1609730 - `text-underline-position:left` and `right` values should be ignored in vertical-sideways writing modes

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, defect, P3)

Description

[Jonathan Kew [:jfkthame]]

Testcase:

data:text/html,<u style="writing-mode:sideways-rl; text-underline-position:right; text-underline-offset:2px">test

This incorrectly renders the underline on the right. According to the spec the left and right values are only applicable to vertical typographic modes. writing-mode:sideways-rl results in text with horizontal typographic mode, just rotated 90°; as such, the right value should be ignored and the underline should remain "under" the text.

(Note that this bug doesn't manifest if text-underline-offset is left at auto; it only appears when a non-auto offset is used.)

Comment 1

[Jonathan Kew [:jfkthame]]

This was noticed while testing the patch in bug 1607308, but as it's somewhat distinct from the primary issue there, I'd like to fix this (and add a testcase) first, before landing the more extensive changes in that bug.

Comment 2

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1609730 - Don't apply text-underline-position:right to sideways text (rotated horizontal typographic mode). r=emilio

Comment 3

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1609730 - Add some extra WPT text-underline-position reftests. r=emilio

Depends on D60351

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/21272 for changes under testing/web-platform/tests

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/21649bdb1cc8
Don't apply text-underline-position:right to sideways text (rotated horizontal typographic mode). r=emilio
https://hg.mozilla.org/integration/autoland/rev/72e73341902f
Add some extra WPT text-underline-position reftests. r=emilio

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 8

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/21649bdb1cc8
https://hg.mozilla.org/mozilla-central/rev/72e73341902f