Make about:privatebrowsing an HTML page
Categories
(Firefox :: Private Browsing, task, P5)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox75 | --- | fixed |
People
(Reporter: ntim, Assigned: jacquelinechan2, Mentored)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug)
Attachments
(1 file)
|
||
Comment 1•5 years ago
|
||
I don't think there's any dependency on this being an xhtml file, so this could be a good first bug, right, Tim?
|
Reporter | |
Comment 2•5 years ago
•
|
||
(In reply to Johann Hofmann [:johannh] from comment #1)
I don't think there's any dependency on this being an xhtml file, so this could be a good first bug, right, Tim?
There's no dependency on being an XHTML file, so yes :)
The steps to fix this bug would be:
- removing
<?xml version="1.0" encoding="UTF-8"?> - (optional, but would be nice to do here too), removing the
typeattribute from those lines https://searchfox.org/mozilla-central/source/browser/components/privatebrowsing/content/aboutPrivateBrowsing.xhtml#12-14 - running
hg mv browser/components/privatebrowsing/content/aboutPrivateBrowsing.xhtml browser/components/privatebrowsing/content/aboutPrivateBrowsing.html
EDIT: forgot one step:
- In browser/components/about/AboutRedirector.cpp and browser/components/privatebrowsing/jar.mn, aboutPrivateBrowsing.xhtml needs to be replaced with aboutPrivateBrowsing.html
|
|
Reporter | |
Comment 3•5 years ago
|
||
Johann, is this something you'd like to mentor ?
|
|
||
Comment 4•5 years ago
|
||
Sure, though you could, too, if you want to.
|
Assignee | |
Comment 5•5 years ago
|
||
Hi, I'd like to tackle a first issue to help me get familiar with the code base and how to contribute to a project in general.
Can I be assigned to this new issue? If I have any questions can I come to you for help? I am a newbie :3
|
|
||
Comment 6•5 years ago
|
||
Hey, sorry for the delay, of course, please let me know if you have any questions!
Hey, I was thinking I might be able to work on this bug, Jacqueline are you still working on it?
|
|
Assignee | |
Comment 8•5 years ago
|
||
(In reply to jcadler from comment #7)
Hey, I was thinking I might be able to work on this bug, Jacqueline are you still working on it?
Yeah I am, I want to do this bug because it looked like a good first issue (and it'll be good because I'm new to this). I just got assigned to it.
Ok great, I'm new as well so just wanted to check. It looks very doable...good luck to you.
|
|
Reporter | |
Comment 10•5 years ago
•
|
||
(In reply to jcadler from comment #9)
Ok great, I'm new as well so just wanted to check. It looks very doable...good luck to you.
There are some similar issues if you're interested: https://bugzilla.mozilla.org/buglist.cgi?bug_id=1609871%2C1609822%2C1609825%2C1609821%2C1609823%2C1609872
I'm happy to mentor any of them :)
|
|
Assignee | |
Comment 11•5 years ago
|
||
Hi Johann, I checked out the files and I also know what I need to do to make the changes in the folders however I was wondering whether you can tell me what the process is to make the patch. I see this documentation here: https://moz-conduit.readthedocs.io/en/latest/walkthrough.html
But I am hesitant because they didn't mention any branching. So would I just make the changes on the default branch, and then just do the commit, and request a review via the command moz-phab ?
|
|
||
Comment 12•5 years ago
|
||
Yup, that sounds correct :)
When your patch has been reviewed on Phabricator, it will be automatically put into a separate "integration" branch. When tests are passing on that branch, your patch is again automatically merged into master ("central").
You should always base your commits on top of the latest central.
Let me know if anything is unclear still.
|
|
Assignee | |
Comment 13•5 years ago
|
||
Hi Johann,
So I made all the bug changes and when I tested the look of the page, I found out that it breaks the styling (even though I did not touch any of css files, only the mention files above)
It looks like this: https://imgur.com/9bFq7gp
I tried to inspect it to further look for the bug but no luck.
Can you please give me a suggestion as to what you suspect the issue is?
|
|
Reporter | |
Comment 14•5 years ago
|
||
(In reply to jacquelinechan2 from comment #13)
Hi Johann,
So I made all the bug changes and when I tested the look of the page, I found out that it breaks the styling (even though I did not touch any of css files, only the mention files above)
It looks like this: https://imgur.com/9bFq7gp
I tried to inspect it to further look for the bug but no luck.
Can you please give me a suggestion as to what you suspect the issue is?
Good catch! Sorry, I forgot that you also needed to correct some tags:
<a href="" id="open-search-options-link" data-l10n-name="link-options" />
needs to become <a href="" id="open-search-options-link" data-l10n-name="link-options"></a>
<div class="logo"/>, <div class="wordmark"/> and <div class="fake-caret"/> need the same adjustment as well.
This is because XHTML handles self-closing tags differently for non-replaced elements (eg. elements that can have children). Self-closing tags still work the same for <link> or <input> elements, because they're replaced and can't have children.
|
|
Assignee | |
Comment 15•5 years ago
|
||
|
|
Assignee | |
Comment 16•5 years ago
|
||
I made my patch request, lemme know if there's anything else to do :)
|
||
Comment 17•5 years ago
|
||
|
|
||
Comment 18•5 years ago
|
||
(In reply to jacquelinechan2 from comment #16)
I made my patch request, lemme know if there's anything else to do :)
You could tackle one of the bugs Tim listed in comment 10. Otherwise, how about bug 1578086 or bug 1583790?
|
||
Comment 19•5 years ago
|
||
| bugherder | ||
Description
•