Closed Bug 1610002 Opened 4 years ago Closed 4 years ago

Status panel should have dark panel and light text in ui.systemUsesDarkTheme=1

Categories

(Firefox :: Theme, enhancement, P3)

enhancement
Points:
2

Tracking

()

VERIFIED FIXED
Firefox 75
Iteration:
74.2 - Jan 20 - Feb 09
Tracking Status
firefox75 --- verified

People

(Reporter: yoasif, Assigned: dao)

References

(Blocks 1 open bug)

Details

(Keywords: parity-chrome)

Attachments

(1 file)

As seen on: https://www.reddit.com/r/firefox/comments/eq1z8b/is_there_a_way_to_remove_this_bar_i_find_it/

Steps to reproduce:

  1. Ensure OS is in dark mode, or set ui.systemUsesDarkTheme=1
  2. Navigate to any page
  3. Hover over a link

What happens:

The status panel that appears shows as it does "light mode".

Expected result:

The status panel should be themed to have a dark background and light text.

Has Regression Range: --- → irrelevant
Keywords: parity-chrome
See Also: → 1408122
Type: defect → enhancement
Priority: -- → P3
No longer blocks: dark-incontent-pages
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → DUPLICATE
See Also: 1408122

This isn't really the same as bug 1454234. One way to address this would be to just make the status panel dark depending on @media (prefers-color-scheme: dark) which I think might be preferable over bug 1454234, because the status panel is visually in the content area and should probably follow content rules rather than the Firefox theme.

Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
See Also: → 1454234
Assignee: nobody → dao+bmo
Status: REOPENED → ASSIGNED
Iteration: --- → 74.2 - Jan 20 - Feb 09
Points: --- → 2
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3f2f6c375baf
Make the status panel respect @media (prefers-color-scheme: dark). r=ntim
Status: ASSIGNED → RESOLVED
Closed: 4 years ago4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 75
Version: 74 Branch → unspecified
Flags: qe-verify+

This enhancement is verified with Fx 76.0a1(2020-03-19) and Fx 75.0b5 on Windows 10 and Ubuntu 18.04.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: