1610085 - No longer possible to override link color

Status: RESOLVED FIXED

(Core :: Layout, defect, P1)

Description

[u532768]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:74.0) Gecko/20100101 Firefox/74.0

Steps to reproduce:

Built latest nightly from hg repo and installed.

Actual results:

Everything seems to work, but links are no longer highlighted in color.

Expected results:

Standard behavior of links being highlighted in color.

Comment 1

[u532768]

I just tried the stable version of firefox here, 72, and it still colors links correctly.

Comment 2

[u532768]

I ran mozregression of the issue. My procedure was to visit a site, and then once I was there to set the color preferences. I changed 'only on high contrast' to 'always', and changed the link colors (green and orange). On the bad versions, the links on the site would be black like regular text. On the good versions, the links would show my new colors. What is strange is that without the changes I made to the colors properties, the links would show as colored, but they wouldn't change after being visited, while they would change after the changes I made in colors preferences. Here is the result of the bisect.

18:17.84 INFO: No more inbound revisions, bisection finished.
18:17.84 INFO: Last good revision: 4fddecc4bdb81585491253a6f3ae4d706947ff0f
18:17.84 INFO: First bad revision: 35612015dd2ceb914abcc2259868942b9b912f95
18:17.84 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=4fddecc4bdb81585491253a6f3ae4d706947ff0f&tochange=35612015dd2ceb914abcc2259868942b9b912f95

Comment 3

[Gingerbread Man]

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:74.0) Gecko/20100101 Firefox/74.0
20200118092217

STR:

1. about:preferences
2. Colors…
3. Unvisited links: red; visited links: yellow; Override the colors…: Always
4. https://en.wikipedia.org/wiki/Main_Page

ER:
Links should be either red or yellow.

AR:
Links are black.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1610085 - Tweak background-color and color handling in ignored-colors mode. r=#style

We're resetting color to the default color when there's a declaration that
applies in order to make stuff like this:

<div style="color: transparent">
<div style="color: red">
Red
</div>
</div>

To not show transparent. But the behavior we want is more like "override with
default color iff there's no other declaration that would set the color from an
user or UA sheet".

This implements that behavior, plus avoids it if we're not inheriting
from transparent, so that stuff like this preserves the behavior from before bug
844349:

<a href="foo">
<span style="color: red">Should be the red color</span>
</a>

Comment 5

[Augusto Pace]

Hi,

I'm able to reproduce this issue on Windows 10 for Firefox version Nightly 74.0a1 (2020-01-23) (64-bit). But NOT in Beta 73.0b8 (64-bit) - Release 72.0.2 (64-bit). Marking those flags as affected and unaffected respectively.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/239f7622187e
Tweak background-color and color handling in ignored-colors mode. r=jwatt

Comment 7

[Natalia Csoregi [:nataliaCs]]

Backed out for background color failures on test_dont_use_document_colors.html.

backout: https://hg.mozilla.org/integration/autoland/rev/93a79d26873bbd2e8d723c2afa3958b5fda8994b

push: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=%2815%29&revision=239f7622187efc0448727676db8106f1e2cd17a8&selectedJob=286548512

failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=286548512&repo=autoland&lineNumber=4447

[task 2020-01-26T20:59:04.756Z] 20:59:04 INFO - TEST-PASS | layout/style/test/test_dont_use_document_colors.html | box-shadow is blocked
[task 2020-01-26T20:59:04.756Z] 20:59:04 INFO - Buffered messages finished
[task 2020-01-26T20:59:04.758Z] 20:59:04 INFO - TEST-UNEXPECTED-FAIL | layout/style/test/test_dont_use_document_colors.html | background-color transparency preserved (opaque) - got "rgb(232, 232, 231)", expected "rgb(255, 255, 255)"
[task 2020-01-26T20:59:04.758Z] 20:59:04 INFO - SimpleTest.is@SimpleTest/SimpleTest.js:325:16
[task 2020-01-26T20:59:04.759Z] 20:59:04 INFO - part2@layout/style/test/test_dont_use_document_colors.html:166:7
[task 2020-01-26T20:59:04.759Z] 20:59:04 INFO - setTimeout handlerSimpleTest_setTimeoutShim@SimpleTest/SimpleTest.js:689:43
[task 2020-01-26T20:59:04.759Z] 20:59:04 INFO - pushPrefEnvAndWait/<@layout/style/test/test_dont_use_document_colors.html:70:15
[task 2020-01-26T20:59:04.759Z] 20:59:04 INFO - AsyncpushPrefEnvAndWait@layout/style/test/test_dont_use_document_colors.html:64:17
[task 2020-01-26T20:59:04.760Z] 20:59:04 INFO - part1@layout/style/test/test_dont_use_document_colors.html:137:23
[task 2020-01-26T20:59:04.760Z] 20:59:04 INFO - setTimeout handlerSimpleTest_setTimeoutShim@SimpleTest/SimpleTest.js:689:43
[task 2020-01-26T20:59:04.760Z] 20:59:04 INFO - pushPrefEnvAndWait/<@layout/style/test/test_dont_use_document_colors.html:70:15
[task 2020-01-26T20:59:04.761Z] 20:59:04 INFO - AsyncpushPrefEnvAndWait@layout/style/test/test_dont_use_document_colors.html:64:17
[task 2020-01-26T20:59:04.761Z] 20:59:04 INFO - @layout/style/test/test_dont_use_document_colors.html:74:19
[task 2020-01-26T20:59:04.762Z] 20:59:04 INFO - Not taking screenshot here: see the one that was previously logged
[task 2020-01-26T20:59:04.762Z] 20:59:04 INFO - TEST-UNEXPECTED-FAIL | layout/style/test/test_dont_use_document_colors.html | color is blocked - got "rgb(46, 52, 54)", expected "rgb(0, 0, 0)"
[task 2020-01-26T20:59:04.762Z] 20:59:04 INFO - SimpleTest.is@SimpleTest/SimpleTest.js:325:16
[task 2020-01-26T20:59:04.763Z] 20:59:04 INFO - part2@layout/style/test/test_dont_use_document_colors.html:167:7
[task 2020-01-26T20:59:04.763Z] 20:59:04 INFO - setTimeout handlerSimpleTest_setTimeoutShim@SimpleTest/SimpleTest.js:689:43
[task 2020-01-26T20:59:04.765Z] 20:59:04 INFO - pushPrefEnvAndWait/<@layout/style/test/test_dont_use_document_colors.html:70:15
[task 2020-01-26T20:59:04.766Z] 20:59:04 INFO - AsyncpushPrefEnvAndWait@layout/style/test/test_dont_use_document_colors.html:64:17
[task 2020-01-26T20:59:04.766Z] 20:59:04 INFO - part1@layout/style/test/test_dont_use_document_colors.html:137:23
[task 2020-01-26T20:59:04.766Z] 20:59:04 INFO - setTimeout handlerSimpleTest_setTimeoutShim@SimpleTest/SimpleTest.js:689:43
[task 2020-01-26T20:59:04.767Z] 20:59:04 INFO - pushPrefEnvAndWait/<@layout/style/test/test_dont_use_document_colors.html:70:15
[task 2020-01-26T20:59:04.767Z] 20:59:04 INFO - AsyncpushPrefEnvAndWait@layout/style/test/test_dont_use_document_colors.html:64:17
[task 2020-01-26T20:59:04.768Z] 20:59:04 INFO - @layout/style/test/test_dont_use_document_colors.html:74:19
[task 2020-01-26T20:59:04.768Z] 20:59:04 INFO - TEST-PASS | layout/style/test/test_dont_use_document_colors.html | border-top-color is blocked

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ebf27510bdd4
Tweak background-color and color handling in ignored-colors mode. r=jwatt

Comment 9

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/ebf27510bdd4

Comment 10

[u532768]

This is working for me in the build of today's nightly. Thank you for the fast turnaround.