1610227 - infinite expansion in firefox extension preference (option ui) page

Status: VERIFIED FIXED

(WebExtensions :: Frontend, defect)

Description

[Sean Feng [:sefeng]]

STR:

1. Clone https://github.com/kalxd/webext-feedback
2. web-ext run
3. Switch to the preference page of this extension

The page would start to expand itself.

Able to reproduce it in Firefox 72 and also Nightly.

I was also able to reproduce it with a simplified version by create a simple optional UI page with these 2 CSS rules

html, body {
    height: 100%;
}

Comment 1

[Mark Striemer [:mstriemer]]

Attachment: Bug 1610227 - Remove page height hack from about:addons inline options r?rpl

Depends on D60555

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6b3433e22d5f
Remove page height hack from about:addons inline options r=rpl

Comment 3

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/6b3433e22d5f

Comment 4

[Miruna Curtean]

Hello,
Could you please attach the extension from step 1 in order to have this fix verified? It can no longer be found on the page where the link redirects to.
Thanks

Comment 5

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: test-bug-1610227-0.1.zip

Hi Miruna,
This attached zip file contains a small test extension that triggers the issue fixed in this bug.

STR:

1. install the attached file as a temporarily installed extension (e.g. by loading it from about:debugging)
2. open about:addons and click on the test extension (to get to the details view)
3. In the extension details view, select the "Preferences" tab available

Non fixed behavior:

• the option page keeps growing in height

Expected fixed behavior:

• the option page doesn't grow and it stays at the initial size

Comment 6

[Miruna Curtean]

Thank you, Luca, for providing the attachment and very clear steps.
Marking this as verified fixed as the Options page under Options (Windows 64-bit) or Preferences (macOS Catalina 10.15) keeps it's initial size.
Successfully tested on FF 74.0a1, Build ID: 20200206093813.