1549450 - Cleanup inline options browser hacks

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, task, P2)

Description

[Mark Striemer [:mstriemer]]

We've collected a series of hacks to make inline options browsers work. We should look into fixing these at the root so we don't need to keep them around.

• content-select-dropdowns element:
  • Select box menupopup/menulist.
  • Context menu element to proxy openPopupAtScreen method.
• inline-options-browser element:
  • frameLoader.requestUpdatePosition() in scroll handler.
  • windowUtils.flushApzRepaints() in scroll handler.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

The flushApzRepaints thing should be removable now that bug 1548687 is in.

Comment 2

[Luca Greco [:rpl] [:luca] [:lgreco]]

Now that the context menu is "Fission-aware" (Bug 1505909, and the "about:addons inline options_page context menu" regression fixed in Bug 1558506) we can also remove this part: https://searchfox.org/mozilla-central/rev/f372470e10c8cb0691681603a1d6324dee5b3b8a/toolkit/mozapps/extensions/content/aboutaddons.js#1045-1053

(basically we can remove the "contextmenu" message manager listener, as it is not sent anymore and there is no point on registering a listener for it, but we still need to keep the ProxyContextMenu custom element definition and its instance in the aboutaddons.html page, to make the context menu internals able to open the expected context menu popup)