1610539 - Autocomplete dropdown is not toggled for some sites with multiple saved logins (on page load when the field is auto-focused)

Status: VERIFIED FIXED

(Toolkit :: Password Manager: Site Compatibility, defect, P2)

Description

[Timea Cernea [:tbabos][inactive]]

Attachment: Log File for Facebook

Unaffected version:
Firefox 70 Release

Affected platforms:
Mac OS 10.13
Ubuntu 16.04
Windows 10

Steps to reproduce:

1. Launch Firefox
2. Go to facebook.com and save 2 set of credentials
3. Reload facebook

2.1. Go to imgur/signin and save 2 credentials
3.1. Reload the login form

Expected:
The autocomplete dropdown should be toggled due to the username field focus on page load

Actual:
The autocomplete dropdown is not automatically toggled. [Facebook]
The autocomplete dropdown is shown a glimpse and is closed [Imgur]
This works in FX70 correctly
Works on reddit.com and github

Regression-Range:
Found Bug 1573836 as the regressor. While it fixed Bug 1548575, seems like it also broke facebook and imgur (not sure how many other sites with field focus on load are affected by this)

Comment 1

[Timea Cernea [:tbabos][inactive]]

Attachment: Comparison to FX70

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Not sure how this got missed in Fx72, but this doesn't sound good.

Comment 3

[Adrian Florinescu [:aflorinescu]]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #2)

Not sure how this got missed in Fx72, but this doesn't sound good.

Usually when an obvious bug gets through QA, there’s no acceptable explanation, however, there are a few factors that led to not catching this bug earlier:

1. The unified Password Manager suite has only been summed up between 71 & 72, first run being only in b72, but the runs on beta only take the high priority / critical marked cases.
2. One fallback on reusing feature test cases and not fully rewriting them for the entire component, is that they will miss low level details: as in this bug, the issue could’ve been easily missed for someone who didn’t have comparison data if there wasn’t a test case specifically for the auto-focus case (and there wasn’t a specific test case for it).
3. Password manager is not a Nightly regression area, hence this couldn’t be caught as part of Nightly Regression testing 72/73/74.
4. The specific feature testing done in b72 focuses on Password generation in private mode, hence the coverage for other areas have been minimal, due to the fact that the critical/high priority areas would be covered by beta validation.
   Password generation in private mode has been treated as a bug work, since the scope was limited to the private mode.
   No web-compatibility coverage for the Password Generation in Private mode, since it was decided that since this feature would be a follow-up of existing Password Generation functionality, unlikely to affect main flows.
5. Most of test cases covering Password manager autofill/autocomplete functionality have an open end to what login forms to be used to test with, so the case might be that the execution touched login forms not affected by this issue.

All in all, the obvious first action item would be to add autofocus specific test case to the high critical tests for Password Manager suite. Further analysis and action courses shall be decided at a later point.

Comment 4

[Matthew N. [:MattN]]

(In reply to Adrian Florinescu [:aflorinescu] from comment #3)

(In reply to Ryan VanderMeulen [:RyanVM] from comment #2)

Not sure how this got missed in Fx72, but this doesn't sound good.

Usually when an obvious bug gets through QA, there’s no acceptable explanation, however, there are a few factors that led to not catching this bug earlier:

IMO the higher level issue is that projects like Fission and de-XBL should be involving QA.

Comment 5

[Neil Deakin]

Attachment: Bug 1610539, don't perform focusing steps when attaching formfill to a document such as a subframe that isn't focused r=MattN

Comment 6

[Timea Cernea [:tbabos][inactive]]

This is also reproducible on vk.com.

Comment 7

[Adrian Florinescu [:aflorinescu]]

Adding more sites to test against, once the bug gets fixed:
In private mode, on ok.ru and quoara.com, with one single login saved, the username being auto-focused, you will get the show-dismiss flicker.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f567747993a7
don't perform focusing steps when attaching formfill to a document such as a subframe that isn't focused r=MattN

Comment 9

[Timea Cernea [:tbabos][inactive]]

Adding livejasmin.com for verification.

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/f567747993a7

Comment 11

[Timea Cernea [:tbabos][inactive]]

Verified - fixed on latest Nightly 74.0a1 (2020-01-31) on Windows 10 x64, Ubuntu 18.04, MacOS 10.15 on following sites:
facebook.com
imgur.com
mail.ru
ok.ru
quora.com
livejasmin.com
vk.com

Waiting for Uplift to Beta.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Should this have gotten an approval request for 73? We're in RC week at this point, so please nominate for release approval if the answer is yes.

Comment 14

[Neil Deakin]

Comment on attachment 9122735 [details]
Bug 1610539, don't perform focusing steps when attaching formfill to a document such as a subframe that isn't focused r=MattN

Beta/Release Uplift Approval Request

• User impact if declined: Some pages (such as facebook and imgur) don't display the autocomplete dropdown on load when multiple logins are present. Some pages with login forms flicker the autocomplete dropdown on load.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Should be low risk. Pages with child iframes were overriding the decision to show the autocomplete popup. Instead only the focused frame is used.
• String changes made/needed: None

Comment 15

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9122735 [details]
Bug 1610539, don't perform focusing steps when attaching formfill to a document such as a subframe that isn't focused r=MattN

Fixes issues with the autocomplete dropdown not appearing on sites when it should. Approved for 73.0RC1.

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/2eec002dbf5a

Comment 17

[Timea Cernea [:tbabos][inactive]]

Verified fixed on Release Candidate 73.0 (ID: 20200203203546) on Windows 10, Mac OS 10.14 and Ubuntu 18.04.