1610610 - Remove remaining NS_ERROR_DOM_TYPE_ERR usage in mediasource

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, task, P3)

Description

[Boris Zbarsky [:bzbarsky]]

A few got missed in bug 1609861 because the tests were not as simple.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1610610 part 1. Throw the right exception from MediaSource::SetDuration. r=jya

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1610610 part 2. Remove unreachable code from MediaSource::EndOfStream. r=jya

There are no values of aError that are not handled by the switch.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1610610 part 3. Fix the exception thrown when a SourceBuffer's mode is set to "segments". r=jya

I tried to write a test for this, but it looks like
mCurrentAttributes.mGenerateTimestamps is only true when the type is "audio/aac"
or "audio/mpeg", and we don't support either of those in MediaSource. So this
code can't actually be reached, as far as I can tell.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/786fbd2c6687
part 1.  Throw the right exception from MediaSource::SetDuration.  r=jya
https://hg.mozilla.org/integration/autoland/rev/cb2ed5d9a5b1
part 2.  Remove unreachable code from MediaSource::EndOfStream.  r=jya
https://hg.mozilla.org/integration/autoland/rev/64dc8647fc6c
part 3.  Fix the exception thrown when a SourceBuffer's mode is set to "segments".  r=jya

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/21331 for changes under testing/web-platform/tests

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 7

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/786fbd2c6687
https://hg.mozilla.org/mozilla-central/rev/cb2ed5d9a5b1
https://hg.mozilla.org/mozilla-central/rev/64dc8647fc6c

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot