1610678 - Prevent code from containing using directives for the mozilla::java namespace

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, enhancement)

Description

[(No longer employed by Mozilla) Aaron Klotz]

It's hard to keep java-based analogs of Gecko types from having naming collisions when code imports the mozilla::java namespace. In bug 1608577 I eradicated such directives from Gecko.

It would be nice to automagically prevent such directives from being landed in the future. While I realize it would be nice to prevent using namespace directives elsewhere in our code, that seems like a bigger project to me.

Comment 1

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Bug 1610678: Add check to clang plugin to raise error when `using namespace mozilla::java` is present in C++ source; r=andi

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/17c2aa0fc93c
Add check to clang plugin to raise error when `using namespace mozilla::java` is present in C++ source; r=andi

Comment 3

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Bug 1610678: Follow-up: Fix build error in MediaDrmCDMProxy.cpp; r=bustage

Comment 4

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Bug 1610678: Follow-up 2 - build fix for AndroidDecoderModule.cpp; r=bustage

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c6eaf183de8a
Follow-up: Fix build error in MediaDrmCDMProxy.cpp; r=bustage CLOSED TREE
https://hg.mozilla.org/integration/autoland/rev/7b43c9ba246a
Follow-up 2 - build fix for AndroidDecoderModule.cpp; r=bustage CLOSED TREE

Comment 6

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/17c2aa0fc93c
https://hg.mozilla.org/mozilla-central/rev/c6eaf183de8a
https://hg.mozilla.org/mozilla-central/rev/7b43c9ba246a