1610986 - RLBox - Update build system to build wasm libs for Mac as well

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement, P3)

Description

[Shravan Narayan]

Currently a new build system that can build wasm libs exists for Linux, however we need to extend this system to support Mac as well. Like the linux system, this must use clang with wasm backend enabled and lucet to produce a wasm file. The build system should respect the same mozconfig and moz.build flags and directives used on Linux.

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: Bug 1610986 - add lucetc and wasi-sysroot to Mac builds; r=#build

Comment 2

[Nathan Froyd [:froydnj]]

Attachment: Bug 1610986 - add a specific target for lucet compilation; r=#build

We're going to need this for handling Mac cross compiles correctly.

Depends on D62795

Comment 3

[Nathan Froyd [:froydnj]]

Attachment: Bug 1610986 - define ldflags for lucetc in configure; r=#build

These vary per-target, and it's nicer to define them here rather than
define them somewhere in rules.mk.

Depends on D62796

Comment 4

[Nathan Froyd [:froydnj]]

Attachment: Bug 1610986 - invoke lucetc with custom LD and LDFLAGS; r=#build

lucetc by default will invoke ld directly, which is usually not what
we want, particularly when cross-compiling. Instead, let's invoke the
compiler, which will do the hard work of determining the correct linker
to use, and we'll also explicitly specify LDFLAGS, since the default
LDFLAGS from lucetc assume you're invoking the linker directly.

Depends on D62797

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e2770c35e64a
add lucetc and wasi-sysroot to Mac builds; r=firefox-build-system-reviewers,rstewart
https://hg.mozilla.org/integration/autoland/rev/1b39526a8a20
add a specific target for lucet compilation; r=firefox-build-system-reviewers,rstewart
https://hg.mozilla.org/integration/autoland/rev/08b3e41cea1e
define ldflags for lucetc in configure; r=firefox-build-system-reviewers,rstewart
https://hg.mozilla.org/integration/autoland/rev/720de9afec70
invoke lucetc with custom LD and LDFLAGS; r=firefox-build-system-reviewers,rstewart

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/e2770c35e64a
https://hg.mozilla.org/mozilla-central/rev/1b39526a8a20
https://hg.mozilla.org/mozilla-central/rev/08b3e41cea1e
https://hg.mozilla.org/mozilla-central/rev/720de9afec70