1610149 - RLBox - permit use of RLBox wasm sandboxes on Mac

Status: RESOLVED FIXED

(Core :: General, enhancement, P3)

Description

[Shravan Narayan]

Currently RLBox is only used to wasm sandbox libraries on Linux 64. However, rlbox as well as the wasm compiler used --- lucet (which uses cranelift) also support Mac 64. We can now expand the use of wasm sandboxed libraries to Mac also.

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: Bug 1610149 - relax SandboxedWasmLibrary assertions in the mozbuild frontend; r=#build

We're going to enable this on Mac, and it won't do to have configure
assert when we actually do so.

Comment 2

[Nathan Froyd [:froydnj]]

Attachment: Bug 1610149 - let x86-64 Mac enable wasm sandboxing; r=#build

Everything that we need is supported on Mac, too.

Depends on D62799

Comment 3

[Nathan Froyd [:froydnj]]

Attachment: Bug 1610149 - turn on wasm sandboxing for Mac configs; r=#build

Depends on D62800

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0568028bb4dd
relax SandboxedWasmLibrary assertions in the mozbuild frontend; r=firefox-build-system-reviewers,rstewart
https://hg.mozilla.org/integration/autoland/rev/dfca4a56fa51
let x86-64 Mac enable wasm sandboxing; r=firefox-build-system-reviewers,rstewart
https://hg.mozilla.org/integration/autoland/rev/b815d0a94385
turn on wasm sandboxing for Mac configs; r=firefox-build-system-reviewers,rstewart

Comment 5

[Cristina Coroiu [:ccoroiu]]

Backed out 3 changesets (bug 1610149) for instr bustage

Backout: https://hg.mozilla.org/integration/autoland/rev/f71caa48f7a5f9e9ebed086a0875c44741376596

Failure push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=b815d0a94385b5271086b8701cf9dbba634290c8&selectedJob=288822564

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=288822564&repo=autoland&lineNumber=1047

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c8d1c7c3bdb1
relax SandboxedWasmLibrary assertions in the mozbuild frontend; r=firefox-build-system-reviewers,rstewart
https://hg.mozilla.org/integration/autoland/rev/afaeeb5d2fb7
let x86-64 Mac enable wasm sandboxing; r=firefox-build-system-reviewers,rstewart
https://hg.mozilla.org/integration/autoland/rev/545bb13ac456
turn on wasm sandboxing for Mac configs; r=firefox-build-system-reviewers,rstewart

Comment 7

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/c8d1c7c3bdb1
https://hg.mozilla.org/mozilla-central/rev/afaeeb5d2fb7
https://hg.mozilla.org/mozilla-central/rev/545bb13ac456

Comment 8

[Marian Raiciof [:marauder]]

Hey Nathan,

Are these regressions expected ?

== Change summary for alert #24968 (as of Mon, 17 Feb 2020 21:41:59 GMT) ==

Regressions:

0.37% installer size osx-shippable opt instrumented 113,688,127.00 -> 114,107,872.17
0.32% installer size osx-shippable opt nightly 80,399,212.92 -> 80,658,855.08

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=24968

Thanks!

Comment 9

[Natalia Csoregi [:nataliaCs]]

We've encountered the following Searchfox(idx) failures on m-c on one of the merges:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=289318409&repo=mozilla-central&lineNumber=937 which pointed at this bug being the culprit.

Emilio, as you are a Searchfox contributor, could you please chime in on this issue? Could we keep tracking it on this bug?
Thank you.

Comment 10

[Nathan Froyd [:froydnj]]

(In reply to Natalia Csoregi [:nataliaCs] from comment #9)

We've encountered the following Searchfox(idx) failures on m-c on one of the merges:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=289318409&repo=mozilla-central&lineNumber=937 which pointed at this bug being the culprit.

Emilio, as you are a Searchfox contributor, could you please chime in on this issue? Could we keep tracking it on this bug?
Thank you.

asuth filed bug 1616281 for it and I'm going to fix it there.

Comment 11

[Nathan Froyd [:froydnj]]

(In reply to Marian Raiciof [:marauder] from comment #8)

Hey Nathan,

Are these regressions expected ?

== Change summary for alert #24968 (as of Mon, 17 Feb 2020 21:41:59 GMT) ==

Regressions:

0.37% installer size osx-shippable opt instrumented 113,688,127.00 -> 114,107,872.17
0.32% installer size osx-shippable opt nightly 80,399,212.92 -> 80,658,855.08

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=24968

Thanks!

I am a bit surprised by this, but this seems comparable to the Linux binary, so I think this is just effects of packaging another library with the build. I don't think there's any reason to open another bug.