1610991 - RLBox - Update rlbox /rlbox_lucet libraries to versions that work on Mac

Status: RESOLVED FIXED

(Core :: General, defect, P3)

Comment 1

[Shravan Narayan]

RLBox API repo and RLBox lucet repo have been tested and updated to support Mac.

The [forked lucet] required some changes to support Mac < 10.12, namely removing uses of libc functions like clock_gettime that were only supported as of Mac 10.12.

We need to bump the in tree versio nof rlbox_lucet repo to get these changes.

Comment 2

[Shravan Narayan]

Attachment: Bug 1610991 - Update rlbox_lucet lib to Mac compatible version r=froydnj

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e0e11528ba44
Update rlbox_lucet lib to Mac compatible version r=froydnj

Comment 4

[Noemi Erli[:noemi_erli]]

Backed out changeset e0e11528ba44 (Bug 1610991) for causing failures in test_memory_usage.py CLOSED TREE

Range: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&classifiedState=unclassified&searchStr=721b88a7e061914c1ec88ef062f5d766d5631b22&fromchange=a3695dec8b662cec2ad29f4f6ce1769875b13bb2&tochange=5cfc30212a8ace869583e4b766b466633661d3ed

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=288275047&repo=autoland&lineNumber=1423
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=288277125&repo=autoland&lineNumber=3570
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=288276072&repo=autoland&lineNumber=4341

Backout: https://hg.mozilla.org/integration/autoland/rev/bf9b2c6d95c6782c4f2c5d6af1157fb8b2a158b7

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

This also caused these wpt-reftest failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=web-platform-tests-reftest&fromchange=567ff72d71662e200541d1afbe69a19b8c442ac1&tochange=bf9b2c6d95c6782c4f2c5d6af1157fb8b2a158b7&selectedJob=288269184

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=288269184&repo=autoland

Comment 6

[Eric Rahm [:erahm]]

We tracked the assertion down to:

[task 2020-02-10T22:57:12.049Z] 22:57:12 INFO - PID 15090 | Error LucetRuntimeError(Unsupported("Module requires feature host does not support: BMI1"))!
[task 2020-02-10T22:57:12.049Z] 22:57:12 INFO - PID 15090 | Sandbox could not be created
[task 2020-02-10T22:57:12.050Z] 22:57:12 INFO - PID 15090 | Redirecting call to abort() to mozalloc_abort

Comment 7

[Nathan Froyd [:froydnj]]

Does that mean that we need https://phabricator.services.mozilla.com/D60166 to limit what features lucet can use at compile time?

Comment 8

[Shravan Narayan]

I'm running some tests now and the flag stating compile time features is likely the missing piece .... Since we are backporting commits here, this version of lucet does requires the target flag.

Here is a repro of the bug without the flag

https://treeherder.mozilla.org/#/jobs?repo=try&revision=66259aaae0f22769fc27cbbb44a4ccac90e6d28c

Here is my test (still ongoing at this time) with the flag enabled

https://treeherder.mozilla.org/#/jobs?repo=try&revision=389483c2c62421b9d8879c9a59198343d5018830

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b897758a9978
Update rlbox_lucet lib to Mac compatible version r=froydnj

Comment 10

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/b897758a9978