Closed Bug 1610999 Opened 3 years ago Closed 3 years ago

Port |Bug 1392221 - FeedWriter doesn't implement nsINavHistoryObserver nor does it need to - so remove it from the QI definition| to SeaMonkey

Categories

(SeaMonkey :: Feed Discovery and Preview, task)

Product:
SeaMonkey
Component:
Feed Discovery and Preview
Type:
task
Priority:
Not set
Severity:
normal

Tracking

(seamonkey2.53 fixed, seamonkey2.57esr fixed)

Status:
RESOLVED FIXED
Milestone:
seamonkey 2.71
Tracking Flags:
Tracking Status
seamonkey2.53 --- fixed
seamonkey2.57esr --- fixed

People

(Reporter: iannbugzilla, Assigned: iannbugzilla)

References

(Blocks 2 open bugs)

Details

(Whiteboard: SM2.53.1)

Attachments

(1 file)

Port simple removal
966 bytes, patch
frg
: review+
frg
: approval-comm-release+
frg
: approval-comm-esr60+
Details | Diff | Splinter Review

FeedWriter is declaring that it implements Ci.nsINavHistoryObserver, but it doesn't need to, nor does it implement it.
Bug 627416 stopped FeedWriter being an observer of Places history, and removed the implementation of that observer, but didn't remove the declaration line.
We can simply remove the line from the QueryInterface definition.

Applies cleanly on all repos

Attachment #9122512 - Flags: review?(frgrahl)
Attachment #9122512 - Flags: approval-comm-release+
Attachment #9122512 - Flags: approval-comm-esr60+
Comment on attachment 9122512 [details] [diff] [review]
Port simple removal

[Approval Request Comment]
Regression caused by (bug #): 627416
User impact if declined: None
Testing completed (on m-c, etc.): all
Risk to taking this patch (and alternatives if risky): none
String changes made by this patch: none
Attachment #9122512 - Flags: approval-comm-release?
Attachment #9122512 - Flags: approval-comm-release+
Attachment #9122512 - Flags: approval-comm-esr60?
Attachment #9122512 - Flags: approval-comm-esr60+
Blocks: 1611010
Blocks: SeaMonkeyTrunkErrors
Comment on attachment 9122512 [details] [diff] [review]
Port simple removal

LGTM
Attachment #9122512 - Flags: review?(frgrahl)
Attachment #9122512 - Flags: review+
Attachment #9122512 - Flags: approval-comm-release?
Attachment #9122512 - Flags: approval-comm-release+
Attachment #9122512 - Flags: approval-comm-esr60?
Attachment #9122512 - Flags: approval-comm-esr60+

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/2bd348484d80
Port |Bug 1392221 - FeedWriter doesn't implement nsINavHistoryObserver nor does it need to - so remove it from the QI definition| to SeaMonkey. r=frg

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey 2.71
status-seamonkey2.53: --- → fixed
status-seamonkey2.57esr: --- → fixed
Whiteboard: SM2.53.1
You need to log in before you can comment on or make changes to this bug.