1611247 - fogotype.<pid> directory is created at every startup of Nightly, but not deleted when the browser closes

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect, P1)

Description

[Alice0775 White]

Reproducible : 100%

Steps to reproduce:

1. Start Nightly74.0a1
2. Quit Nightly
3. Observe temp directory
4. Repeat from step 1

Actual Results:
fogotype.xxx directory are created indefinitely

Expected Results:
The directory should be deleted when the browser closes

Comment 1

[Chris H-C :chutten]

Gah, sorry about that. I should've caught that in review. We should clean that up.

The directories are safe to delete and Firefox's behaviour should be unaffected. It is an artefact of a piece of prototype code.

Comment 2

[Jan-Erik Rediger [:janerik]]

That already was the case before we switched to "fogotype.xyz" directories (that is: /tmp/db and /tmp/events stuck around).
Right now the fogotype doesn't handle lifecycle at all, so it doesn't know about shutdown and because it does run in its own thread, we don't have any good way of notifying it just yet.

Dropping priority because I won't get to it before All Hands. After that we should have a plan how to move forward with the prototype (e.g. whether we make it a more serious prototype first or rip it out)

Comment 3

[Klaus P. Kuhlemann]

Same bug in thunderbird Daily since 2020-01-28.

Comment 4

[Mark]

Would this bug also account for the multitude of mat-debug-nnnn.log files also appearing in the %temp% directory?

Comment 5

[Alice0775 White]

(In reply to Mark from comment #4)

Would this bug also account for the multitude of mat-debug-nnnn.log files also appearing in the %temp% directory?

no

mat-debug-nnnn.log files seems to be created by a Microsoft Program(MicrosoftOffice) called LocalBridge.exe.

See, https://answers.microsoft.com/en-us/windows/forum/all/mat-debug-xxxxlog-files/8875d070-62f9-429b-b3e1-9a6e006c45be

Comment 6

[Worcester12345]

(In reply to Chris H-C :chutten from comment #1)

Gah, sorry about that. I should've caught that in review. We should clean that up.

The directories are safe to delete and Firefox's behaviour should be unaffected. It is an artefact of a piece of prototype code.

Is there anything that needs to be done, or will whatever the fix is here delete all the directories already created?

Comment 7

[Pascal Chevrel (relman team) -> :pascalc]

Jan Erik, is that a nightly-only regression or will it impact 74 beta with the merge next Monday? Thanks

Comment 8

[Jan-Erik Rediger [:janerik]]

It should be nightly only (compile-time gated).
As this is the first time we're doing it, :chutten is keeping an eye out on the beta merge next week and is ready to revert the patches there if we find out it's not working as intended.

This is definitely not planned to land in beta/release.

Comment 9

[Jan-Erik Rediger [:janerik]]

With bug 1614923 landing the FOGotype will go away and thus not create new temporary directories.
We're not going to clean up existing temporary directories.

Comment 10

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/message/reply/question/etc.)]

(In reply to Jan-Erik Rediger [:janerik] from comment #9)

We're not going to clean up existing temporary directories.

Any reason for this?

FYI - Windows never automatically cleans TEMP directory by default, so Mozilla Firefox will leave its bloat which made hundreds of folders undeleted.

Comment 11

[Chris H-C :chutten]

I had a little extra bandwidth this week to look at this. This should be removed after a couple days/week of being in tree.

Comment 12

[Chris H-C :chutten]

Attachment: Bug 1611247 - Clean up stray fogotype dirs on idle. r?janerik

The FOGotype put some dirs into the os tmpdir. Generally we think this is
harmless, but it doesn't take too much code to safely try to clean up.

FOGotype was nightly-only and is now disabled, so this patch should only
need to live for a little while before reverting.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2763c2934546
Clean up stray fogotype dirs on idle. r=janerik

Comment 14

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/2763c2934546

Comment 15

[Julien Cristau [:jcristau]]

This is not an issue in beta (74) per comment 8.