Closed Bug 1611425 (webgpu-v1-bgl-dedup) Opened 5 years ago Closed 1 years ago

Deduplicate WebGPU bindgrouplayouts

Categories

(Core :: Graphics: WebGPU, defect, P1)

Product:
Core
Component:
Graphics: WebGPU
Type:
defect

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: kvark, Assigned: nical)

References

(Blocks 1 open bug,
URL
)

Details

The semantics of GPUBindGroupLayout is defined "by-value". Therefore, two layouts created from the same descriptor are considered the same layout. Originally, we tried to resolve this on the wgpu-core level by returning an existing ID. However, this isn't possible with remote case, where the ID is already provided from above.

Perhaps, we could deduplicate at the level of WebGPU bindings in C++, instead.

This is blocking http://austin-eng.com/webgpu-samples/samples/reversedZ from rendering correctly. It's quite an annoying thing to fix.

Severity: normal → S3

Fixed in https://github.com/gfx-rs/wgpu/pull/753

Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED

Woops, there was a misunderstanding about the fix from https://github.com/gfx-rs/wgpu/pull/753, it does not apply to gecko because our identity factory thingamagingy is not a ZST so we still need this gap bridged in firefox.

Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Summary: Deduplicate WebGPU bind group layouts → Deduplicate WebGPU bindgrouplayouts
Assignee: nobody → nical.bugzilla
Priority: P3 → P1
Type: enhancement → defect
Alias: webgpu-v1-bgl-dedup
See Also: → 1851721
Status: REOPENED → RESOLVED
Closed: 2 years ago → 1 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.