1806659 - (webgpu-official-samples) [meta] Ensure that official WebGPU samples work (except for `rgba16float` canvas formats)

Status: REOPENED

(Core :: Graphics: WebGPU, task, P3)

Description

[Nicolas Silva [:nical]]

Meta bug to track outstanding spec compliance and stability issues preventing us from running WebGPU demos (picking Austing Eng's because I think they are to date withe the spec https://austin-eng.com/webgpu-samples)

Comment 1

[Erich Gubler [:ErichDonGubler] (he/him)]

Fun fact: The link in the description now redirects to https://webgpu.github.io/webgpu-samples/.

Comment 2

[Erich Gubler [:ErichDonGubler] (he/him)]

VideoFrame blocks the videoUploadingWebCodecs demo specifically.

Comment 3

[Jim Blandy :jimb]

We're not going to worry about video import for now.

Comment 4

[Nicolas Silva [:nical]]

As of early january 2024:

• [x] helloTriangle
• [x] helloTriangleMSAA
• [ ] resizeCanvas
• [x] rotatingCube
• [x] twoCubes
• [x] texturedCube
• [x] instancedCube
• [x] fractalCube
• [x] cameras
• [x] cubemap
• [ ] computeBoids
  • error: createQuerySet is not a function
• [x] animometer
• [ ] videoUploading
• [ ] videoUploadingWebCodecs
• [ ] samplerParameters
  • blocked on override expressions
• [ ] imageBlur
  • blocked on const declarations in functions
• [ ] shadowMapping
  • blocked on override expressions
• [x] reversedZ
• [ ] deferredRendering
  • blocked on const declarations in functions
• [ ] particles
  • Maybe blocked on abstract types

Shader validation error: 
    ┌─ :109:26
    │
109 │     for (var level = u32(textureNumLevels(texture) - 1); level > 0; level--) {
    │                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ naga::Expression [54]

• [ ] cornell
  • blocked on override expressions
• [ ] gameOfLife
  • blocked on override expressions
• [ ] renderBundles
  • Maybe blocked on abstract types

Shader validation error: 
   ┌─ :42:44
   │
42 │   let lightColor = saturate(ambientColor + max(dot(input.normal, lightDir), 0.0) * dirColor);
   │                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ naga::Expression [13]

• [ ] worker
• [ ] A-buffer
  • blocked on const declarations in functions
• [ ] bitonicSort
  • blocked on const declarations in functions and abstract types
• [ ] normalMap
  • blocked on abstract types

Comment 5

[Nick]

https://webgpu.github.io/webgpu-samples/?sample=worker

My main complaint with this for now is the silent failure -- in FF Nightly there is not even an error message to state what is happening -- the sample code, or any other code like my own that is written with WebGPU in a WebWorker, fails silently.

Comment 6

[Erich Gubler [:ErichDonGubler] (he/him)]

As of 2024-12-13 on my M1 MacBook Pro, I note the following remaining failures; most of these entries show the console errors when the page is loaded:

• Blocked on bug 1829879:

  • cubemap:

    Shader validation error: Entry point main at Fragment is invalid
       ┌─ :16:3
       │
    16 │   cubemapVec.z *= -1;
       │   ^^^^^^^^^^^^^^^^^^ naga::Expression [10]
       │
       = Expression [10] is invalid
       = Operation Multiply can't work with [9] (of type Scalar(Scalar { kind: Float, width: 4 })) and [8] (of type Scalar(Scalar { kind: Sint, width: 4 }))
    

  • renderBundles

    Shader validation error: Entry point fragmentMain at Fragment is invalid
       ┌─ :42:44
       │
    42 │   let lightColor = saturate(ambientColor + max(dot(input.normal, lightDir), 0.0) * dirColor);
       │                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ naga::Expression [12]
       │
       = Expression [12] is invalid
       = Operation Multiply can't work with [10] (of type Scalar(Scalar { kind: Float, width: 4 })) and [11] (of type Vector { size: Tri, scalar: Scalar { kind: Sint, width: 4 } })
    

  • samplerParameters:

    Shader '' parsing error: automatic conversions cannot convert elements of `i32` to `u32`
       ┌─ wgsl:25:21
       │
    25 │   let mipSize = f32(1 << (kMipLevels - mipLevel));
       │                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
       │                     │     │
       │                     │     this expression has type i32
       │                     a value with elements of type u32 is required here
    

  • bitonicSort

    Shader '' parsing error: invalid switch value
       ┌─ wgsl:91:10
       │
    91 │     case 1: { // Local Flip
       │          ^ expected unsigned integer
       │
       = note: suffix the integer with a `u`: '1u'
    

  • normalMap

    Shader 'NormalMappingRender.vertexShader' parsing error: invalid switch value
       ┌─ wgsl:82:10
       │
    82 │     case modeParallaxScale: {
       │          ^^^^^^^^^^^^^^^^^ expected unsigned integer
       │
       = note: suffix the integer with a `u`: 'modeParallaxScaleu'
    

  • cornell

    Shader '' parsing error: failed to convert expression to a concrete type: the concrete type `i32` cannot represent the abstract value `2947058881` accurately
        ┌─ wgsl:237:13
        │  
    237 │     const A = vec3(1741651 * 1009,
        │ ╭─────────────^
    238 │ │                  140893  * 1609 * 13,
    239 │ │                  6521    * 983  * 7 * 2);
        │ ╰────────────────────────────────────────^ this expression has type vec3<{AbstractInt}>
        │  
        = note: the expression should have been converted to have i32 scalar type
    

  • skinnedMesh

    Shader '' parsing error: invalid switch value
       ┌─ wgsl:76:10
       │
    76 │     case 1: {
       │          ^ expected unsigned integer
       │
       = note: suffix the integer with a `u`: '1u'
    

  • metaballs

    Shader validation error: Function [1] 'surfaceFunc' is invalid
       ┌─ Metaball Isosurface Compute Shader:31:3
       │  
    31 │ ╭   fn surfaceFunc(position : vec3f) -> f32 {
    32 │ │     var result = 0.0;
    33 │ │ 
    34 │ │     // Always render geometry on the floor
    35 │ │     if ((position.x*position.x + position.z*position.z < 1.1) && position.y < 0) {
    36 │ │       return 100;
       │ │              ^^^ naga::Expression [16]
       · │
    46 │ │     }
    47 │ │     return result;
       │ ╰──────────────────^ naga::Function [1]
       │  
       = The `return` value Some([16]) does not match the function return value
    

  • alphaToCoverageEmulator

    Shader validation error: Function [1] 'uvToAlpha' is invalid
       ┌─ :82:1
       │  
    82 │ ╭ fn uvToAlpha(uv: vec2f) -> f32 {
    83 │ │   let kRadius = 1.0;
    84 │ │   // t is a signed distance field which is >1 inside the circle and <1 outside.
    85 │ │   let t = kRadius - length(uv);
       · │
    89 │ │   //let divisor = fwidth(t) * uniforms.featheringWidthPx;
    90 │ │   return clamp(t / max(divisor, 0.0001), 0, 1);
       │ │          ^^^^^ naga::Expression [17]
       │ ╰───────────────────────────────────────────────^ naga::Function [1]
       │  
       = Expression [17] is invalid
       = Argument [1] to Clamp as expression [15] has an invalid type.
    

  • particles

    Shader validation error: Entry point simulate at Compute is invalid
        ┌─ :119:26
        │
    119 │       let probabilites = textureLoad(texture, coord, level);
        │                          ^^^^^^^^^^^ naga::Expression [62]
        │
        = Expression [62] is invalid
        = Image sample or level-of-detail index's type of [61] is not an integer scalar
    

• gameOfLife is blocked by bug 1937105.

  Shader '' parsing error: Unexpected override-expression
     ┌─ wgsl:24:26
     │
  24 │ @compute @workgroup_size(blockSize, blockSize)
     │                          ^^^^^^^^^ see msg
  

• a-buffer is blocked by bug 1937126.

  Shader 'compositeModule' parsing error: this operation is not supported in a const context
     ┌─ wgsl:54:40
     │
  54 │   var layers: array<LinkedListElement, maxLayers>;
     │                                        ^^^^^^^^^ operation not supported here
  

• resizeObserverHDDPI: Renders a blank screen. 😬 Didn't triage the issue beyond finding that, since my time available for triage is limited.

• videoUploading is still blocked by bug 1827116.

  Shader '' parsing error: unknown type: 'texture_external'
    ┌─ wgsl:2:38
    │
  2 │ @group(0) @binding(2) var myTexture: texture_external;
    │                                      ^^^^^^^^^^^^^^^^ unknown type
  

• The following depend on bug 1930972/the dom.webgpu.indirect-draw pref. for indirect draws, but otherwise work as expected:

  • bundleCulling
  • marchingCubes; this also has some stuttering that I've reported as bug 1937100.

• spookyball's rendering works, but for some reason, the mouse input is really inconsistent; the player's paddle jumps around even if the cursor is making smooth motions or holding still. Maybe it's the same root cause as bug 1930005?

Overall, we have a lot fewer failures than the start of the year! 🙌🏻

Comment 7

[Erich Gubler [:ErichDonGubler] (he/him)]

gameOfLife is now resolved; edited my latest index comment.

Comment 8

[Jim Blandy :jimb]

One of Mozilla's partners has indicated that videoUploading (note, no WebCodecs) is critical to them. Let's be sure to include that in our goals.

That is: https://webgpu.github.io/webgpu-samples/?sample=videoUploading

Comment 9

[Andy Leiserson [:aleiserson]]

Triage as of nightly build 20250411092938, on Mac:

Fixed since previous update:

• cubemap
• renderBundles
• normalMap
• skinnedMesh
• alphaToCoverageEmulator
• a-buffer
• spookyball seems to me like it is working. The input handling is not great, but seems to me to be equivalent to Chrome.

New symptom since previous update:

• bitonicSort: Argument to atomic operation is not promoted correctly. Filed bug 1960093.
• samplerParameters: Pipeline constant error in ShaderStages(FRAGMENT) shader: MSL: MissingValue("kTextureBaseSize"). Existing bug 1953930.
• cornell: Pipeline constant error: MSL: MissingValue("AccumulationToLightmapWorkgroupSizeX"). Existing bug 1953930.
• metaballs: Now blocked on indirect draw. Existing bug 1930972.
• particles: Number of bindings in bind group descriptor (4) does not match the number of bindings defined in the bind group layout (3). Filed bug 1960112.
• resizeObserverHDDPI: renders, but there are transient artifacts when resizing that do not appear in Chrome. Filed bug 1960101.

No change:

• videoUploading: bug 1827116
• bundleCulling / marchingCubes: bug 1930972

Comment 10

[Erich Gubler [:ErichDonGubler] (he/him)]

Diff since last update:

• metaballs, bundleCulling, and marchingCubes are now resolved.

• On Windows, animometer and renderBundles reports an OOM issue that invalidates the device (bug 1962806)

   Uncaught Error: uncaught exception, please report a bug!
     https://github.com/webgpu/webgpu-samples/issues/new
   Error: Uncaptured error:
   Not enough memory left.
  

  I cannot reproduce this issue on macOS, on which these demos work fine now.

• On Windows, bitonicSort now causes a crash in the CanvasRenderer thread, reporting device loss with WebGPUChild destroyed; filed bug 1962807.

  On macOS, this crash does not happen, though the demo does go significantly more slowly than in Chrome Beta on Windows.

Running list of observed problems (mostly tested on Windows 11):

• animometer and renderBundles have crashes on Windows (see above).
• Bug 1953930: These continue to report Pipeline constant error in ShaderStages(FRAGMENT) shader: …:
  • samplerParameters: MissingValue("kTextureBaseSize")
  • cornell: MissingValue("AccumulationToLightmapWorkgroupSizeX")
• bitonicSort now runs on macOS, though there's a new crashing issue on Windows (see above).
• particles fails and reports OperationError: GPUCanvasContext.getCurrentTexture: Canvas not configured in the console (bug 1967329).
• a-buffer's alpha blending is wrong, but otherwise runs. This seems like a similar root cause to bug 1911502.
• resizeObserverHDDPI continues to display artifacts on resize (bug 1960101).
• marchingCubes continues to struggle to do more than a few frames per second (bug 1937100, which need not keep this bug open).

Comment 11

[Jim Blandy :jimb]

• samplerParameters continues to report Pipeline constant error in ShaderStages(FRAGMENT) shader: HLSL: MissingValue("kTextureBaseSize").
• cornell continues to report Pipeline constant error in ShaderStages(FRAGMENT) shader: HLSL: MissingValue("AccumulationToLightmapWorkgroupSizeX").

Andy and I expect his work here to fix the above: https://github.com/gfx-rs/wgpu/issues/5885

Comment 12

[Andy Leiserson [:aleiserson]]

Bug 1834395 tracks the cause of the current failure in the particles demo, GPUCanvasContext.getCurrentTexture: Canvas not configured. This error appears concurrently with the errors due to bug 1960112 in affected builds. In my triage on April 11, I must have either missed this issue, or assumed it was a consequence of the other problem.

Comment 13

[Andy Leiserson [:aleiserson]]

Changed the link for the particles demo to bug 1834395.

Comment 14

[Jim Blandy :jimb]

Since Firefox won't support rgba16float presentation in 2025H1, the particles demo is now out of scope for this bug.

Comment 15

[Teodor Tanasoaia [:teoxoy]]

I tested all samples on macOS, almost all work, 3 run into known issues:

• https://webgpu.github.io/webgpu-samples/?sample=particles (Bug 1834395, platform agnostic)
• https://webgpu.github.io/webgpu-samples/?sample=resizeObserverHDDPI (Bug 1960101, platform agnostic)
• (new sample) https://webgpu.github.io/webgpu-samples/?sample=primitivePicking (Bug 1989116, platform agnostic)