1611584 - xpidl.xpidl.IDLError: error: Interface 'nsIAbBooleanConditionTypes' must inherit from nsISupports

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Richard Marti (:Paenglab)]

With c-c and m-c on tip I get following failure:
xpidl.xpidl.IDLError: error: Interface 'nsIAbBooleanConditionTypes' must inherit from nsISupports, z:/Mozilla/comm-central/comm/mailnews/addrbook/public/nsIAbBooleanExpression.idl line 19:0

Backout of bug 1611173 let me build successfully.

Comment 1

[Magnus Melin [:mkmelin]]

Looks like I got it building.

Comment 2

[Magnus Melin [:mkmelin]]

Attachment: bug1611584_idl_nsISupports.patch

I think this should do it. Local building hasn't finished yet.

Comment 3

[Richard Marti (:Paenglab)]

Comment on attachment 9123039 [details] [diff] [review]
bug1611584_idl_nsISupports.patch

I'm far away to know C++ but it builds for me, so rs=me

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/3b281b9a0b40
Port "Bug 1611173 - Remove support for non-nsISupports XPIDL interfaces" to Thunderbird. r=bustage-fix

Comment 5

[Magnus Melin [:mkmelin]]

Andrew, just to understand it better, Thunderbird used a bunch of these constants only interfaces. Is there something we could do different?

Comment 6

[Andrew McCreight (out until 2026) [:mccr8]]

(In reply to Magnus Melin [:mkmelin] from comment #5)

Andrew, just to understand it better, Thunderbird used a bunch of these constants only interfaces. Is there something we could do different?

No, this is the right fix. I just wanted to get rid of some XPConnect corner cases that dealt with these interfaces, and it doesn't seem like there's any drawback to requiring that they inherit from nsISupports, aside from the one-time cost of fixing things up. Sorry for the hassle.