Closed Bug 161166 Opened 22 years ago Closed 22 years ago

Freeze more DOM interfaces

Categories

(Core :: DOM: Core & HTML, defect, P1)

x86
Windows 2000
defect

Tracking

()

RESOLVED FIXED
mozilla1.3beta

People

(Reporter: chak, Assigned: jst)

References

Details

(Keywords: topembed+, Whiteboard: [HAVE FIX])

Attachments

(1 file)

The following DOM interfaces need to be frozen:

nsIDOMHTMLElement
nsIDOMHTMLImageElement
nsIDOMHTMLBaseElement
nsIDOMHTMLInputElement
nsIDOMHTMLBodyElement
nsIDOMHTMLAreaElement
nsIDOMHTMLIFrameElement
nsIDOMHTMLFrameElement
nsIDOMHTMLAppletElement
nsIDOMHTMLDocument
nsIDOMHTMLCollection
nsIDOMRange
nsIDOMMouseEvent
Keywords: topembed+
Priority: -- → P1
Target Milestone: --- → mozilla1.2alpha
Blocks: 157137
Adding a few more interfaces that are missing here but were discussed/agreed as
ready to freeze at the 9/5/02 meeting (see
news://news.mozilla.org:119/3D764F94.8040606@netscape.com)

nsIDOMAbstractView
nsIDOMCSSPrimitiveValue
nsIDOMCSSRule
nsIDOMCSSRuleList
nsIDOMCSSStyleSheet
nsIDOMCSSStyleDeclaration
nsIDOMCSSValue
nsIDOMCSSValueList
nsIDOMDocumentRange
nsIDOMDocumentStyle
nsIDOMDocumentView
nsIDOMEventReceiver 
nsIDOMHTMLImageElement 
nsIDOMMediaList
nsIDOMStyleSheet
nsIDOMUIEvent

There may be others ready to be frozen as well.  Johnny, the 1.2 branch is going
to be cut pretty soon.  Are these on track?
Target Milestone: mozilla1.2alpha → mozilla1.3alpha
Attached patch FixSplinter Review
This patch freezes everything but nsIDOMEventReceiver, which is an internal
interface that AFAICT no embedders should ever need to use.
Attachment #110380 - Flags: superreview?(peterv)
Attachment #110380 - Flags: review?(harishd)
Status: NEW → ASSIGNED
Whiteboard: [HAVE FIX[
Target Milestone: mozilla1.3alpha → mozilla1.3beta
Comment on attachment 110380 [details] [diff] [review]
Fix

r=harishd
Attachment #110380 - Flags: review?(harishd) → review+
Comment on attachment 110380 [details] [diff] [review]
Fix

>Index: dom/public/idl/html/nsIDOMHTMLDocument.idl
>===================================================================

-document exception on cookie
-document why open is noscript

>Index: dom/public/idl/range/nsIDOMRange.idl
>===================================================================

-document exception on endContainer
		       endOffset
		       collapsed
-rename the "parent" argument in setStart to "refNode"
-in the comment "// CompareHow Group", remove "Group"
Attachment #110380 - Flags: superreview?(peterv) → superreview+
Johnny, before you land this for nsIDOMHTMLIFrameElement, could you at least
have one more look at bug 170554?  I think we do want a focus() method, but do
we want it in this iface, or in a NS iface?
If we'd want a focus() method on [i]frame's we'd want that in
nsIDOMNSHTMLIFrameElement, not in nsIDOMHTMLIFrameElement.
Whiteboard: [HAVE FIX[ → [HAVE FIX]
That's what I figured, but just thought I'd check.
Fixed, except that the interface nsIDOMEventReceiver is *not* frozen, that's an
internal interface that no embedders should rely on, therefore it should not
need to be frozen.
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
maybe it's a good idea to add a comment in nsIDOMEventReceiver saying that it is
internal, so that embedders don't rely on it and so that it doesn't accidently
gets frozen in the future. (i guess this applies to a lot of interfaces though)
Component: DOM: Core → DOM: Core & HTML
QA Contact: stummala → general
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: