161166 - Freeze more DOM interfaces

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P1)

Description

[Chak Nanga]

The following DOM interfaces need to be frozen:

nsIDOMHTMLElement
nsIDOMHTMLImageElement
nsIDOMHTMLBaseElement
nsIDOMHTMLInputElement
nsIDOMHTMLBodyElement
nsIDOMHTMLAreaElement
nsIDOMHTMLIFrameElement
nsIDOMHTMLFrameElement
nsIDOMHTMLAppletElement
nsIDOMHTMLDocument
nsIDOMHTMLCollection
nsIDOMRange
nsIDOMMouseEvent

Comment 1

[Juan José Mata]

Adding a few more interfaces that are missing here but were discussed/agreed as
ready to freeze at the 9/5/02 meeting (see
news://news.mozilla.org:119/[e-mail])

nsIDOMAbstractView
nsIDOMCSSPrimitiveValue
nsIDOMCSSRule
nsIDOMCSSRuleList
nsIDOMCSSStyleSheet
nsIDOMCSSStyleDeclaration
nsIDOMCSSValue
nsIDOMCSSValueList
nsIDOMDocumentRange
nsIDOMDocumentStyle
nsIDOMDocumentView
nsIDOMEventReceiver 
nsIDOMHTMLImageElement 
nsIDOMMediaList
nsIDOMStyleSheet
nsIDOMUIEvent

There may be others ready to be frozen as well.  Johnny, the 1.2 branch is going
to be cut pretty soon.  Are these on track?

Comment 2

[Johnny Stenback (:jst)]

Attachment: Fix

This patch freezes everything but nsIDOMEventReceiver, which is an internal
interface that AFAICT no embedders should ever need to use.

Comment 3

[harishd]

Comment on attachment 110380 [details] [diff] [review]
Fix

r=harishd

Comment 4

[Peter Van der Beken [:peterv]]

Comment on attachment 110380 [details] [diff] [review]
Fix

>Index: dom/public/idl/html/nsIDOMHTMLDocument.idl
>===================================================================

-document exception on cookie
-document why open is noscript

>Index: dom/public/idl/range/nsIDOMRange.idl
>===================================================================

-document exception on endContainer
		       endOffset
		       collapsed
-rename the "parent" argument in setStart to "refNode"
-in the comment "// CompareHow Group", remove "Group"

Comment 5

[Christopher Aillon (sabbatical, not receiving bugmail)]

Johnny, before you land this for nsIDOMHTMLIFrameElement, could you at least
have one more look at bug 170554?  I think we do want a focus() method, but do
we want it in this iface, or in a NS iface?

Comment 6

[Johnny Stenback (:jst)]

If we'd want a focus() method on [i]frame's we'd want that in
nsIDOMNSHTMLIFrameElement, not in nsIDOMHTMLIFrameElement.

Comment 7

[Christopher Aillon (sabbatical, not receiving bugmail)]

That's what I figured, but just thought I'd check.

Comment 8

[Johnny Stenback (:jst)]

Fixed, except that the interface nsIDOMEventReceiver is *not* frozen, that's an
internal interface that no embedders should rely on, therefore it should not
need to be frozen.

Comment 9

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

maybe it's a good idea to add a comment in nsIDOMEventReceiver saying that it is
internal, so that embedders don't rely on it and so that it doesn't accidently
gets frozen in the future. (i guess this applies to a lot of interfaces though)