1611727 - GetProcAddress is not needed for rstrtmgr.dll functions anymore

Status: RESOLVED WONTFIX

(Toolkit :: Startup and Profile System, defect, P5)

Description

[Alex Henrie]

ProfileUnlockerWin.cpp currently calls GetProcAddress to get pointers to various functions in rstrtmgr.dll (and one function in kernel32.dll). This is no longer necessary because all of these functions are guaranteed to be available from Windows Vista on, and Firefox no longer supports Windows XP.

Comment 1

[Alex Henrie]

Okay, it looks like we can't link to rstrtmgr.dll quite yet because MinGW doesn't have support for rstrtmgr.dll yet, so the build fails on the try server. While we're waiting for that to be fixed, I have opened Bug 1611745 about the use of GetProcAddress for QueryFullProcessImageNameW in ProfileUnlockerWin.cpp.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:mossop, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 3

[Alex Henrie]

MinGW supports rstrtmgr.dll now, so I think at this point it's safe to start linking to it directly.

Comment 4

[Alex Henrie]

Attachment: Bug 1611727 - Link to Rstrtmgr.dll at compile time.

Comment 5

[Alex Henrie]

Per the discussion at https://phabricator.services.mozilla.com/D99967#3264089, it seems that we're better off staying with run-time linkage here because the code is only called on a rare error path. Therefore I am closing this bug.