1611878 - Issues when loading tabs are discarded.

Status: RESOLVED DUPLICATE of bug 1630167

(WebExtensions :: Frontend, defect)

Description

[anon]

User Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:73.0) Gecko/20100101 Firefox/73.0

Steps to reproduce:

1. Install the 'Unload Tab' extension. Some tab discarding extensions will not discard loading tabs, but this one will.
2. Open a bookmark that takes a while to load in a background tab.
3. Select 'Unload Tab' in that tabs menu while it is loading (after the tab title has updated).

Actual results:

Once the tab has been discarded in step #3, the tab throbber continues to stay active even though the page is no longer loading. This can be checked with a network monitor. Retrieving the tab details though a get or query will show the tab status as "loading" and the discarded property as false. If the tab is clicked on, it will reload like a tab that has been discarded.

Expected results:

A webNavigation.onErrorOccurred event should probably fire, signaling that the pages navigation has been aborted (it currently doesn't fire). The tab status should be "complete" and the discarded property should be true. The loading animation should no longer continue.

There are also problems if the tab is discarded really fast, like through the following command:

browser.tabs.create({url: "https://www.google.com", active: false}).then(tab => browser.tabs.discard(tab.id));

In most cases the tab loading animation doesn't happen, the tab status is "complete" and the discarded property is false, though the tab behaves like a discarded tab when clicked. However, in some cases the tab throbber will show the loading animation, the tab status will be "loading", and the discarded property will be true. The previous situation will also occur when discarding a tab that will have a network connection timeout error, like when loading http://example.com:81/ .

Comment 1

[Clara Guerrero ( Need Info Brindusa Tot Please)]

Hi,

Is this the extension you refer to? https://addons.mozilla.org/es/firefox/addon/unload-tabs/

Thanks for the details. I was able to reproduce on Windows 10 pro, on the following versions

Firefox Nightly version 75.0a1 (2020-02-14) (64-bit),d
Beta 74.0b3 (64-bit)
Release 73.0 (64-bit)

I will move this over to a component so developers can take a look over it. (If is not the correct component please feel free to change it to an appropriate one.)

Thanks for the report.
Best,
Clara

Comment 2

[ariasuni]

Copied from here:

Steps to reproduce:

• Install tabs-tabs-tabs[1], Tab Center Reborn[2] or any other extension that has the tabs permission
  [1]: https://github.com/mdn/webextensions-examples/tree/master/tabs-tabs-tabs
  [2]: https://addons.mozilla.org/firefox/addon/tabcenter-reborn/
• Type await browser.tabs.query({}); and get the id of a tab you can discard
• Type await browser.tabs.reload(tabId); setTimeout(() => browser.tabs.discard(tabId), 30); by using the the tab id of above.

Note that this is not a theoretical case I can trigger it by doing F5 and unloading the tab with an extension that adds a context menu entry to do that.

Actual results:

Tab is discarded but the loading spinner doesn’t go away.

await browser.tabs.get(tabId); reports the tab as both discarded: true and status: loading.

Expected results:

– Discarded tab get back its favicon, instead of the loading spinner.
– WebExtensions API reports its status as complete instead of loading like for other discarded tabs.

Comment 3

[Shane Caraveo (:mixedpuppy)]

unable to reproduce, much of the STR looks the same as bug 1630167