1630167 - Loading spinner animates forever if tabs is discarded while loading

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect, P1)

Description

[ariasuni]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:76.0) Gecko/20100101 Firefox/76.0

Steps to reproduce:

1. Install tabs-tabs-tabs[1], Tab Center Reborn[2] or any other extension that has the tabs permission
   [1]: https://github.com/mdn/webextensions-examples/tree/master/tabs-tabs-tabs
   [2]: https://addons.mozilla.org/firefox/addon/tabcenter-reborn/
2. Type await browser.tabs.query({}); and get the id of a tab you can discard
3. Type await browser.tabs.reload(tabId); setTimeout(() => browser.tabs.discard(tabId), 30); by using the the tab id of above.

Note that this is not a theoretical case I can trigger it by doing F5 and unloading the tab with an extension that adds a context menu entry to do that.

Actual results:

Tab is discarded but the loading spinner doesn’t go away.

await browser.tabs.get(tabId); reports the tab as both discarded: true and status: loading.

Expected results:

– Discarded tab get back its favicon, instead of the loading spinner.
– WebExtensions API reports its status as complete instead of loading like for other discarded tabs.

Comment 1

[ariasuni]

I wrote this whole report just to see that it has already been reported as bug 1611878.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 3

[Shane Caraveo (:mixedpuppy)]

This is an issue in tabbrowser.

Comment 4

[Dão Gottwald [:dao]]

Attachment: Bug 1630167 - Remove busy, progress, pendingicon attributes when discarding browser. r=mixedpuppy

Comment 5

[Firefox Bug Husbandry Bot]

Resetting severity to default of --.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/501574a6e645
Remove busy, progress, pendingicon attributes when discarding browser. r=mixedpuppy

Comment 7

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/501574a6e645

Comment 9

[Gyula Palko[:gpalko]]

Verified- Fixed on latest Nightly 78.0a1 and Beta 77.0b3

Comment 11

[ariasuni]

I still have this problem on Dev Edition 87.0b8 and Nightly 88.0a1.