Open Bug 1612181 Opened 4 years ago Updated 2 years ago

fails to build with clang on FreeBSD powerpc64

Categories

(Core :: XPCOM, defect, P3)

Product:
Core
Component:
XPCOM
Version:
72 Branch
Platform:
Other
FreeBSD
Type:
defect

Tracking

()

Tracking Flags:
Tracking Status
firefox-esr68 --- affected
firefox72 --- affected
firefox73 --- affected
firefox74 --- affected

People

(Reporter: mikael.urankar, Unassigned)

Details

(Whiteboard: [npotb])

Attachments

(2 files)

firefox.patch
6.61 KB, patch
froydnj
: review+
Details | Diff | Splinter Review
patch-xpcom_reflect_xptcall_md_unix_moz.build
531 bytes, patch
Details | Diff | Splinter Review
Attached patch firefox.patch — — Splinter Review

User Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:72.0) Gecko/20100101 Firefox/72.0

Actual results:

firefox fails to build on FreeBSD powerpc64 with these errors:

/usr/local/bin/clang90 -std=gnu99 -o xptcstubs_asm_ppc64_linux.o -DNDEBUG=1 -DTRIMMED=1 -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -fPIC -Wa,--noexecstack -include /usr/local/poudriere/ports/default/www/firefox-ppc64/work/.build/mozilla-config.h -DMOZILLA_CLIENT -I/usr/local/poudriere/ports/default/www/firefox-ppc64/work/firefox-71.0/xpcom/reflect/xptcall -c /usr/local/poudriere/ports/default/www/firefox-ppc64/work/firefox-71.0/xpcom/reflect/xptcall/md/unix/xptcstubs_asm_ppc64_linux.S
/usr/local/poudriere/ports/default/www/firefox-ppc64/work/firefox-71.0/xpcom/reflect/xptcall/md/unix/xptcstubs_asm_ppc64_linux.S:61:21: error: invalid memory operand
std r4, -56(r1) # Save all GPRS
...
lots of error of the same kind

/usr/local/bin/clang90 -std=gnu99 -o xptcinvoke_asm_ppc64_linux.o -DNDEBUG=1 -DTRIMMED=1 -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -fPIC -Wa,--noexecstack -include /usr/local/poudriere/ports/default/www/firefox-ppc64/work/.build/mozilla-config.h -DMOZILLA_CLIENT -I/usr/local/poudriere/ports/default/www/firefox-ppc64/work/firefox-71.0/xpcom/reflect/xptcall -c /usr/local/poudriere/ports/default/www/firefox-ppc64/work/firefox-71.0/xpcom/reflect/xptcall/md/unix/xptcinvoke_asm_ppc64_linux.S
/usr/local/poudriere/ports/default/www/firefox-ppc64/work/firefox-71.0/xpcom/reflect/xptcall/md/unix/xptcinvoke_asm_ppc64_linux.S:65:18: error: invalid memory operand
std 0,16(r1)

...
lots of error of the same kind

full error logs:
http://mikael.urankar.free.fr/FreeBSD/powerpc64/firefox_xptcinvoke_error.txt
http://mikael.urankar.free.fr/FreeBSD/powerpc64/firefox_xptcstubs_error.txt

/usr/local/bin/clang90 -v
clang version 9.0.0 (tags/RELEASE_900/final)
Target: powerpc64-portbld-freebsd13.0

The attached patch fixes the issue

Component: Untriaged → General: Unsupported Platforms
OS: Unspecified → FreeBSD
Product: Firefox → Firefox Build System
Hardware: Unspecified → Other
Attachment #9123550 - Flags: review?(nfroyd)
status-firefox72: --- → affected
status-firefox73: --- → affected
status-firefox74: --- → affected
status-firefox-esr68: --- → affected
Component: General: Unsupported Platforms → XPCOM
Product: Firefox Build System → Core
Whiteboard: [npotb]
Comment on attachment 9123550 [details] [diff] [review]
firefox.patch

Sure, seems fine.  It's going to have to wind up in phabricator, I think, to be able to land it.
Attachment #9123550 - Flags: review?(nfroyd) → review+
Status: UNCONFIRMED → NEW
Ever confirmed: true
Priority: -- → P3

Do I have to open a review in phab for this issue? What's the url?

Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: