1612184 - fix build on FreeBSD powerpc64

Status: RESOLVED FIXED

(Firefox Build System :: General, defect, P4)

Description

[Mikael Urankar]

Attachment: firefox.patch

User Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:72.0) Gecko/20100101 Firefox/72.0

Actual results:

The attached patch is needed to build Firefox on FreeBSD/powerpc64

Comment 1

[Jan Beich]

Comment on attachment 9123551 [details] [diff] [review]
firefox.patch

> -        if CONFIG['CC_TYPE'] == 'clang':
> +        if CONFIG['CC_TYPE'] == 'clang' and CONFIG['OS_ARCH'] != 'FreeBSD':

Can you move this part to bug 1612181? Also, reformat the patch, so it can be applied via `hg import` or `git am` to avoid other people introducing mistakes on landing.

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 9123551 [details] [diff] [review]
firefox.patch

Review of attachment 9123551 [details] [diff] [review]:
-----------------------------------------------------------------

::: media/webrtc/trunk/webrtc/moz.build.orig
@@ +294,5 @@
> +if CONFIG["CPU_ARCH"] == "ppc64" and CONFIG["OS_TARGET"] == "FreeBSD":
> +
> +    DIRS += [
> +        "/media/webrtc/trunk/webrtc/api/audio_codecs/isac/audio_decoder_isac_float_gn",
> +        "/media/webrtc/trunk/webrtc/api/audio_codecs/isac/audio_encoder_isac_float_gn"

This bit is not the right place to modify; I think the right thing to do here is to add a GN config for ppc64 FreeBSD in media/webrtc/gn-configs/, and then regenerate the moz.build files.

Comment 3

[Mikael Urankar]

Attachment: patch-media_webrtc_gn-configs_freebsd_ppc64

Patch for media/webrtc/gn-configs

Comment 4

[Mike Hommey [:glandium]]

This was probably fixed by bug 1773223 and subsequent gn-related changes. Please reopen if that's not the case, and provide fresh information.