1612238 - Alt+Left and Alt+Right for Back and Forward have stopped working

Status: VERIFIED FIXED

(Core :: DOM: UI Events & Focus Handling, defect, P1)

Description

[Chris Morgan]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:74.0) Gecko/20100101 Firefox/74.0

Steps to reproduce:

Press Alt+Left or Alt+Right.

Actual results:

Nothing. (No navigation, no viewport scrolling.)

Expected results:

Alt+Left should have navigated backwards, and Alt+Right forwards.

This is a recent regression; I think the last build I was on was 2020-01-19 and it aworked then, but 2020-01-29 is broken.

Other relevant matters:

• This is not a hardware problem: Alt+Left and Alt+Right are still working in other browsers.

• This is not a webpage content problem (e.g. JavaScript intercepting the key combo): all pages are demonstrating the issue, including Firefox built-in pages and pages with no JavaScript.

• Backspace for navigating backwards still works.

Comment 1

[Gingerbread Man]

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:74.0) Gecko/20100101 Firefox/74.0
20200129213721

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=31e91b3d071e6b7a1453b8a89e2e60e60a7a6760&tochange=b94005dcae8194883459523083392cee0f67e2a4

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Ah, simple mistake. Arrow keys are same scan code as some numpad keys except extended flags, but I forgot to check it.

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1612238 - Make `NativeKey::IsTypingUnicodeScalarValue()` check `mIsExtended` r=m_kato!

Scan code values of numpad keys are same as End, ArrowDown, PageDown,
Insert, ArrowLeft, ArrowRight, Home, ArrowUp and PageUp. Only
the difference between them is that numpad keys are non-extended keys and
the others are extended keys. Therefore, IsTypingUnicodeScalarValue() needs
to check whether the key is not extended key or not.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e7c1df27d856
Make `NativeKey::IsTypingUnicodeScalarValue()` check `mIsExtended` r=m_kato

Comment 5

[Alin Ilea, Desktop Test Engineering]

Updating the Flags for this issue, I was able to reproduce this issue only in Nightly 74.0a1, Release and Beta remain unaffected.

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/e7c1df27d856

Comment 7

[Chris Morgan]

Thanks for the rapid fix, this is just what Nightly and using Nightly is for. 🙂

Comment 8

[Alin Ilea, Desktop Test Engineering]

Reproduced the initial issue using an old Nightly build 74.0a1 (Build id: 20200131013147).
Verified - Fixed in latest Nightly build 74.0a1 (Build id: 20200202214642) using Windows 10.